[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-15 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-727797419 @kaxil @RosterIn I've added the docs and example dag. Please have a look. This is an automated message from th

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-21 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-731581208 @kaxil one test is failing with this error: > E AssertionError: Lists differ: ['apa[2132 chars]ders-vertica', 'apache-airflow-providers-yande[34 chars]esk'] != ['apa[2

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-21 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-731606107 Thanks @mik-laj This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-24 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-733138203 Thank you @kaxil I've added the entry in https://github.com/apache/airflow/blob/master/tests/core/test_providers_manager.py#L22-L83 static checks are passing locally

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-27 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-734861771 Thanks @kaxil. Building docs still failed with: ``` Warning, treated as error: failed to reach any of the inventories with the following issues: intersphinx inventor

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-27 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-734898709 Thanks @mik-laj Will do that. I was using `./breeze build-docs` locally to test it, which was working. This i

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-27 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-735050101 Things are passing locally. Let's hope this is it 🤞 @mik-laj yes, build_docs.py is much much faster :) Thi

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-27 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-735051502 Failed with same error 🤔 https://user-images.githubusercontent.com/4328561/100496416-ebb14800-3179-11eb-80b5-6a76d913da1d.png";> --

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-01 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-737019905 @mik-laj https://github.com/apache/airflow/pull/12681/files is merged now. I'll try this and see if it works.

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-738984810 Thanks for asking @mik-laj no issues, I couldn't get time to rebase and push. Just did, let's see how it goes. It works locally. -

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739134322 @mik-laj what's the new location for howto docs for providers? This is an automated message from the Apache Gi

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739135668 @mik-laj Where do we place this file? It is `howto` for the telegram operator. https://github.com/apache/airflow/blob/1e7568de54a56d43ec3d47d248932fbd11ffd10b/docs/howto/op

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-03 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-720921259 @kaxil What's the right place to add package dependencies? I see it's not requirements.txt, Is setup.py the right place? As I can see it has all deps. (just wanted to confirm)

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-11 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-725839722 @kaxil Please review. I'll fix the two conflicting files, looks like it gets changed in master frequently enough.

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-12 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-726265464 @RosterIn I've added telegram there. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739137357 Thanks @mik-laj That helped. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-05 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739148205 @mik-laj Static checks :sob: ``` Items in the first set but not the second: '/docs/apache-airflow-providers-telegram/operators.rst' ``` also, not sure how it pa

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-05 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739198195 @mik-laj everything passes, except `CI Build / Postgres9.6,Py3.6: Always Core Other API CLI Providers WWW Integration Heisentests (pull_request) Failing after 45m` I don't see

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-05 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739241985 Thanks @kaxil @mik-laj and others. This PR was a marathon :) This is an automated message from the Apache Git