[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-27 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r621485511 ## File path: airflow/providers/mongo/hooks/mongo.py ## @@ -40,11 +40,12 @@ class MongoHook(BaseHook): ex. {"srv": true, "replicaSet": "t

[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-20 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r617006726 ## File path: airflow/providers/apache/spark/hooks/spark_jdbc.py ## @@ -31,7 +31,8 @@ class SparkJDBCHook(SparkSubmitHook): :param spark_app_nam

[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-20 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r617006726 ## File path: airflow/providers/apache/spark/hooks/spark_jdbc.py ## @@ -31,7 +31,8 @@ class SparkJDBCHook(SparkSubmitHook): :param spark_app_nam

[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-19 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r616129114 ## File path: airflow/providers/apache/spark/hooks/spark_jdbc.py ## @@ -31,7 +31,8 @@ class SparkJDBCHook(SparkSubmitHook): :param spark_app_nam

[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-19 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r615928528 ## File path: docs/apache-airflow-providers-mongo/connections/mongo.rst ## @@ -0,0 +1,82 @@ +.. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] sunkickr commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

2021-04-16 Thread GitBox
sunkickr commented on a change in pull request #15393: URL: https://github.com/apache/airflow/pull/15393#discussion_r614938268 ## File path: airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py ## @@ -34,8 +34,9 @@ class SparkKubernetesOperator(BaseOperator): :t