uranusjr commented on a change in pull request #14725:
URL: https://github.com/apache/airflow/pull/14725#discussion_r593725061



##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -1618,7 +1618,7 @@ do the same, but then it is more suitable to use a 
virtualenv and pip.
     mkdir zip_dag_contents
     cd zip_dag_contents
 
-    pip install --install-option="--install-lib=$PWD" my_useful_package
+    pip install --prefix=$PWD my_useful_package

Review comment:
       ```suggestion
       pip install --target=$PWD my_useful_package
   ```
   
   Re-reading the context, the zip file is loaded directly into `sys.path`, so 
I think it should use `pip install --target` instead. `--prefix` would give you 
a nested prefix structure (e.g. Python packages are installed into 
`$PREFIX/lib/pythonX.Y/site-packages`). `--target` gives you a flat structure 
that can be directly loaded into `sys.path`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to