[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-13 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1166056086 ## airflow/dag_processing/processor.py: ## @@ -187,6 +188,18 @@ def _handle_dag_file_processing(): def start(self) -> None: """Launch the process and

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-12 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1165064625 ## tests/dags/test_imports.nopy: ## @@ -0,0 +1,26 @@ +# using .nopy extension so that the file won't get reformatted +# because we want to assert that we can parse c

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-12 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1165058081 ## airflow/dag_processing/processor.py: ## @@ -187,6 +188,18 @@ def _handle_dag_file_processing(): def start(self) -> None: """Launch the process and

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-12 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1163964902 ## airflow/dag_processing/processor.py: ## @@ -187,6 +188,19 @@ def _handle_dag_file_processing(): def start(self) -> None: """Launch the process and

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-11 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1162503167 ## airflow/dag_processing/processor.py: ## @@ -187,6 +188,19 @@ def _handle_dag_file_processing(): def start(self) -> None: """Launch the process and

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-11 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1162502632 ## airflow/utils/file.py: ## @@ -371,3 +372,22 @@ def might_contain_dag_via_default_heuristic(file_path: str, zip_file: zipfile.Zi content = dag_file.r

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-10 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1161541662 ## airflow/utils/file.py: ## @@ -371,3 +371,14 @@ def might_contain_dag_via_default_heuristic(file_path: str, zip_file: zipfile.Zi content = dag_file.r

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-06 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1159424262 ## airflow/utils/file.py: ## @@ -371,3 +371,14 @@ def might_contain_dag_via_default_heuristic(file_path: str, zip_file: zipfile.Zi content = dag_file.r

[GitHub] [airflow] uranusjr commented on a diff in pull request #30495: preload airflow imports before dag parsing to save time

2023-04-06 Thread via GitHub
uranusjr commented on code in PR #30495: URL: https://github.com/apache/airflow/pull/30495#discussion_r1159423802 ## airflow/utils/file.py: ## @@ -371,3 +371,14 @@ def might_contain_dag_via_default_heuristic(file_path: str, zip_file: zipfile.Zi content = dag_file.r