uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-897654921
Yeah they are failing on `main` as well, I think we recently changed
something that caused a SQL incompatibility in the Python 3.6 + MySQL
combination. I plan to take a look
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-897360425
Hmm, it’s still failing, but now for a different version-db combination. I’m
going to say it’s flaky and not related…
--
This is an automated message from the Apache Git
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-897340148
Doesn’t repro locally. Let’s try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-897326965
`TestSchedulerJob.test_verify_integrity_if_dag_not_changed` Huh that’s new,
need to investigate a bit.
--
This is an automated message from the Apache Git Service.
To
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-891859321
Note: I’ve changed `schedule_date` in this PR to `logical_date` as I
mentioned on the dev mailing list:
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-891181187
I think this is ready for another round of reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-888915907
Turns out I already indirectly test the `data_interval` fields are populated
in `test_task_get_template` (this tests the template context is correctly
populated; and since
uranusjr commented on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-57967
Are there existing tests on manual runs? I know there are tests on scheduled
and backfill runs (I modified some of those in this PR), but not manual ones.
Or should I just
