uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900172063
I think an assert would be better than the `task_terminated_externally`
check. It’s better to not depend on too much logic to trigger a test failure.
--
This is an
uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900159470
There are several
```python
# This should not happen.
time.sleep(10)
```
usages in the tests. I wonder if we should add an `assert False, "This
should
uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900156495
Note: The MSSQL job was red since it’s killed midway, so I think it’s safe
to assume all tests are passing right now.
--
This is an automated message from the Apache Git
