[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-18 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-945874974 Either `dag_id_pattern` or `dag_id_ilike` would work for me. I prefer `pattern` slightly since `ilike` is kind of leaking the database internals into the interface, but I gue

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-13 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941688196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941710663 My Django root tells me to choose `dag_id__contains` but I understand it's not a universally loved approash :p -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941688196 Not objecting to the idea (although what's wrong with fetching the entire list and filter yourself?) but I feel `search` is not a particularly good name for this. -- This