[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
utkarsharma2 commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1251608982 ## tests/providers/odbc/hooks/test_odbc.py: ## @@ -235,3 +259,15 @@ def test_sqlalchemy_scheme_extra(self): hook = self.get_hook(conn_params=dict(extra

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
utkarsharma2 commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1251604927 ## tests/providers/odbc/hooks/test_odbc.py: ## @@ -19,31 +19,55 @@ import json import logging +from collections import namedtuple from unittest import mock

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
utkarsharma2 commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1251604306 ## airflow/providers/odbc/hooks/odbc.py: ## @@ -65,6 +67,7 @@ def __init__( dsn: str | None = None, connect_kwargs: dict | None = None,

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-02 Thread via GitHub
utkarsharma2 commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1250224162 ## airflow/providers/odbc/hooks/odbc.py: ## @@ -211,3 +211,10 @@ def get_sqlalchemy_connection( engine = self.get_sqlalchemy_engine(engine_kwargs=engine