[GitHub] [airflow] vandonr-amz commented on a diff in pull request #31838: Various fixes on ECS run task operator

2023-06-16 Thread via GitHub
vandonr-amz commented on code in PR #31838: URL: https://github.com/apache/airflow/pull/31838#discussion_r1232431989 ## tests/system/providers/amazon/aws/example_ecs.py: ## @@ -85,6 +93,7 @@ def get_region(): asg_name = f"{env_id}-asg" aws_region = get_region() +

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #31838: Various fixes on ECS run task operator

2023-06-13 Thread via GitHub
vandonr-amz commented on code in PR #31838: URL: https://github.com/apache/airflow/pull/31838#discussion_r1228401390 ## airflow/providers/amazon/aws/operators/ecs.py: ## @@ -506,25 +515,24 @@ def execute(self, context, session=None): @AwsBaseHook.retry(should_retry_eni)

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #31838: Various fixes on ECS run task operator

2023-06-10 Thread via GitHub
vandonr-amz commented on code in PR #31838: URL: https://github.com/apache/airflow/pull/31838#discussion_r1225658167 ## tests/system/providers/amazon/aws/example_ecs.py: ## @@ -67,6 +66,15 @@ def get_region(): return boto3.session.Session().region_name +@task(trigger_ru