[GitHub] [airflow] vincbeck commented on pull request #22737: Deprecate S3PrefixSensor

2022-04-11 Thread GitBox
vincbeck commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1095518033 I also edited the PR description to add a section to explain the purpose of `default_check_fn` since it might not be very obvious -- This is an automated message from the Apache Git

[GitHub] [airflow] vincbeck commented on pull request #22737: Deprecate S3PrefixSensor

2022-04-11 Thread GitBox
vincbeck commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1095517182 I only left tests related to deprecation warnings and default function in `TestS3KeySizeSensor`. I removed the other tests because these use cases are already covered in

[GitHub] [airflow] vincbeck commented on pull request #22737: Deprecate S3PrefixSensor

2022-04-08 Thread GitBox
vincbeck commented on PR #22737: URL: https://github.com/apache/airflow/pull/22737#issuecomment-1093263722 While working on addressing feedbacks from this PR I realized that `S3KeySizeSensor` is also a subset of `S3KeySensor`. Thus I also decided to deprecate it and added an optional