zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-572539351
Thank Jarek's and Kamil's help on this patch. ❤️
This is an automated mess
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571391602
Code now sort by long option and CI green, the behavior like below
```sh
usage: airflow tasks run [-h] [--cfg_path CFG_PATH] [-f]
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-571005760
We still have discuss in
https://github.com/apache/airflow/pull/6881#issuecomment-570850316, It's will
be great if @potiuk @mik-laj to shar
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570933284
Don't merge this PR as we still have discuss in
https://github.com/apache/airflow/pull/6881#issuecomment-570850316
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570932007
> It's so odd in
https://travis-ci.org/apache/airflow/jobs/632880273?utm_medium=notification&utm_source=github_status
> Both `tests/test_
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570927761
It's so odd in
https://travis-ci.org/apache/airflow/jobs/632880273?utm_medium=notification&utm_source=github_status
Both `tests/test_impe
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570924726
> Does it bother others? Or is it just me ? Should we maybe fix that?
Yeah, I think is a problem too, short option represent turn on o
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850651
> What do you think about not ignoring case (key= lambda d: d.lower())?
I agree with you this point, but different with others, the re
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570850316
> What do you think about not ignoring leading dash (key= lambda d:
d.lstrip('-'))?
I think maybe we should keep the dash, when we use si
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570813787
Finally I found out CI failed due to
`for arg in sorted(sub['args'], key=lambda x: cls.args[x].flags[0]):`
and the error message is
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-570749730
I run `test/test_core.py` local in Airflow breeze, and found out unittest
`test_local_task_job` failed random , the failed reason is **Timeo
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-569397951
@mik-laj Thanks for approving, but Travis still sad
This is an automated m
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-568624951
Mistake commit with others patch I submit
This is an automated message fro
zhongjiajie commented on issue #6881: [AIRFLOW-6326] Sort cli commands and arg
URL: https://github.com/apache/airflow/pull/6881#issuecomment-568376875
All Travis-CI failed due to Timeout, force-push to start CI
This is an auto
14 matches
Mail list logo
