[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-03-02 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r261847959 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-28 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r261476559 ## File path: airflow/contrib/operators/azure_container_instances_operator.py ## @@ -18,6 +18,9 @@ # under the

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-15 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r257444670 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-12 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r256252901 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-12 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r256251232 ## File path: airflow/contrib/operators/adls_list_operator.py ## @@ -46,7 +48,7 @@ class AzureDataLakeStorageLis

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255808194 ## File path: setup.py ## @@ -319,6 +318,7 @@ def do_setup(): 'sqlalchemy>=1.1.15, <1.3.0',

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255788761 ## File path: airflow/config_templates/airflow_local_settings.py ## @@ -19,6 +19,8 @@ import os +from typin

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255788477 ## File path: airflow/bin/cli.py ## @@ -1665,9 +1665,17 @@ def sync_perm(args): dag.access_control)

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255773545 ## File path: airflow/contrib/operators/adls_list_operator.py ## @@ -46,7 +48,7 @@ class AzureDataLakeStorageLis

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255769937 ## File path: airflow/models/__init__.py ## @@ -1014,9 +1019,8 @@ def are_dependents_done(self, session=None):

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255768340 ## File path: airflow/www/views.py ## @@ -82,7 +83,7 @@ PAGE_SIZE = conf.getint('webserver', 'page_size') if

[GitHub] jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy.

2019-02-11 Thread GitBox
jmcarp commented on a change in pull request #4685: [AIRFLOW-3862] Check types with mypy. URL: https://github.com/apache/airflow/pull/4685#discussion_r255767116 ## File path: airflow/models/__init__.py ## @@ -3085,6 +3094,7 @@ def __init__( self.partial = False