Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-09-03 Thread via GitHub
hadarsharon commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2325901918 I just checked and can confirm that this issue is resolved in [v2.10.1.rc1](https://pypi.python.org/pypi/apache-airflow/2.10.1.rc1) Cheers -- This is an automated mess

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-09-02 Thread via GitHub
potiuk commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2325725859 > Yeah, this is what I was trying to get at, with these old hybrids, you're constantly trying to let the individual executors do their individual thing, then you have to merge the r

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-09-01 Thread via GitHub
potiuk closed issue #41891: 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' URL: https://github.com/apache/airflow/issues/41891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
o-nikolas commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322216440 > well i guess it kindof is kindof is a problem since each of the executors would write to the queue on their individual instances, oy, yeah let's 🪓 these hybrid executors ... si

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322096935 > so it's not really a problem for hybrid executors well i guess it kindof is kindof is a problem since each of the executors would write to the queue on their individual i

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322092430 Alright, let's see how https://github.com/apache/airflow/pull/41904 does in CI -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322084734 yeah `_task_event_logs` is just a deque that is there so that the executor can pass messages for the scheduler to consume. it's there because the executor does not have access t

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
o-nikolas commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322074424 Yeah, the hybrid executors never have inherited from the base executor, since what would it mean for the wrapper class to have `_task_event_logs` property for example? What you r

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322050187 I will PR the inheritance fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322032855 > Executors from older versions of provider will definitely not have the new _task_event_logs property They will if they inherit from BaseExecutor, which they all should.

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
dstandish commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2322030348 I think the problem is that CKE does not inherit from BaseExecutor, but that code assumes that it does. -- This is an automated message from the Apache Git Service. To respond

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
o-nikolas commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2321948408 > I guess a discussion and proposal for that should happen - do you want to open it ? I guess we have some arguments and evidences already that we can use I'm happy to open

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
potiuk commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2321845677 I see. I guess a discussion and proposal for that should happen - do you want to open it ? I guess we have some arguments and evidences already that we can use. We could also potent

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
o-nikolas commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2321749536 @potiuk This one is not related to the new hybrid/multiple executor config changes. It's actually related to the recent changes to remove the task context logger in favour of the

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
potiuk commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2321409008 FYI: @o-nikolas - looks similar to https://github.com/apache/airflow/issues/41525 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
hadarsharon opened a new issue, #41891: URL: https://github.com/apache/airflow/issues/41891 ### Apache Airflow version 2.10.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When running tasks using the `CeleryKubernete

Re: [I] 'CeleryKubernetesExecutor' object has no attribute '_task_event_logs' [airflow]

2024-08-30 Thread via GitHub
boring-cyborg[bot] commented on issue #41891: URL: https://github.com/apache/airflow/issues/41891#issuecomment-2321243708 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap