Re: [I] Extend Notifier interface [airflow]

2023-12-21 Thread via GitHub
potiuk closed issue #35381: Extend Notifier interface URL: https://github.com/apache/airflow/issues/35381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] Extend Notifier interface [airflow]

2023-12-01 Thread via GitHub
vchiapaikeo commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1836239909 Happy to give this a shot. Will likely start work on it next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
potiuk commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792294117 > > We define three predefined templates for each case > > How do you suggest to use it? How can user point to a specific template? I thought about three cases we have

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
eladkal commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792128488 > We define three predefined templates for each case How do you suggest to use it? How can user point to a specific template? -- This is an automated message from the Ap

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
eladkal commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792124425 > I understand the ask for email "templates", but don't think a "mode" argument with a limited set of options will suit. For example, for one project I made subclasses such as `Tea

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
potiuk commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792108885 I think the ideas of the three of you should be combined into one :) We can have predefined set of templates based on "action" that triggered the notification. And allow

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
potiuk commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792109287 Sorry clolsed it by total mistake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
potiuk commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792099327 I think the ideas of the three of you should be combined into one :) We can have predefined set of templates based on "action" that triggered the notification. And allow

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
potiuk closed issue #35381: Extend Notifier interface URL: https://github.com/apache/airflow/issues/35381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] Extend Notifier interface [airflow]

2023-11-03 Thread via GitHub
BasPH commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792076053 I understand the ask for email "templates", but don't think a "mode" argument with a limited set of options will suit. For example, for one project I made subclasses such as `Team1Su

Re: [I] Extend Notifier interface [airflow]

2023-11-02 Thread via GitHub
hussein-awala commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1791741821 I confirm that most Airflow users create subclasses to add their default values to the official classes, and there are no problems with that, especially for the users who nee

[I] Extend Notifier interface [airflow]

2023-11-02 Thread via GitHub
eladkal opened a new issue, #35381: URL: https://github.com/apache/airflow/issues/35381 ### Body Notifiers is a really cool feature. I have been using it for a while and it's simplify the use case for writing callable functions for alerts. But... it has also one big drawback.