Re: [I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-03-16 Thread via GitHub
shahar1 commented on issue #36484: URL: https://github.com/apache/airflow/issues/36484#issuecomment-2001977683 It took a while, but the pre-commit is now operational with no exceptions :) There's still some work to do to improve it, but hopefully, now it will become a bit easier to detect

Re: [I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-03-09 Thread via GitHub
eladkal commented on issue #36484: URL: https://github.com/apache/airflow/issues/36484#issuecomment-1986899687 > > I believe all entries are fixed now? > > Almost, we still have #37519 open. Thanks everyone for helping out :) I think it was fixed in another PR? -- This is an

Re: [I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-03-09 Thread via GitHub
shahar1 commented on issue #36484: URL: https://github.com/apache/airflow/issues/36484#issuecomment-1986896702 > I believe all entries are fixed now? Almost, we still have #37519 open. Thanks everyone for helping out :) -- This is an automated message from the Apache Git Service.

Re: [I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-03-04 Thread via GitHub
eladkal commented on issue #36484: URL: https://github.com/apache/airflow/issues/36484#issuecomment-1977562409 I believe all entries are fixed now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-03-03 Thread via GitHub
shahar1 opened a new issue, #36484: URL: https://github.com/apache/airflow/issues/36484 ### Introduction PR #33786 aims to prevent templated field logic in `__init__` method of operators automatically by introducing a new pre-commit that validates each operator (see added limitations in

Re: [I] Fix existing custom operators' templated fields that include logic checks [airflow]

2024-01-20 Thread via GitHub
eladkal commented on issue #36484: URL: https://github.com/apache/airflow/issues/36484#issuecomment-1902124528 Closing as explained in https://github.com/apache/airflow/pull/33786#issuecomment-1902071627 -- This is an automated message from the Apache Git Service. To respond to the messag

[I] Fix existing custom operators' templated fields that include logic checks [airflow]

2023-12-29 Thread via GitHub
shahar1 opened a new issue, #36484: URL: https://github.com/apache/airflow/issues/36484 ### Apache Airflow version main (development) ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? ### Introduction PR #33786 aims to