[I] Overriding Additional ECS Task Properties [airflow]

2023-11-06 Thread via GitHub
o-nikolas opened a new issue, #35490: URL: https://github.com/apache/airflow/issues/35490 ### Description From feedback [here](https://github.com/apache/airflow/pull/34381#issuecomment-1796224734): The executor config [is scoped to overrides.containerOverrides](https://github.

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-11-09 Thread via GitHub
o-nikolas commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1804920164 I started working on this one and there is a bit of nuance that I didn't expect. Many of the config options are lists of dicts. Take tags for example, the type is: ```

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-11-10 Thread via GitHub
mshober commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1806100741 Thanks for starting this @o-nikolas! It is important to note that you can use `propagateTags=TASK_DEFINITION` as a way of setting default tags to all the tasks that Airflow

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-11-13 Thread via GitHub
o-nikolas commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1808741730 > Thanks for starting this @o-nikolas! > > It is important to note that you can use `propagateTags=TASK_DEFINITION` as a way of setting default tags to all the tasks that A

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-12-01 Thread via GitHub
ferruzzi commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1836785447 I think tags should be additive AFAIK it will always be a list of len(1) and we should have an order of precedence; just tags[0]update() it so they get appended or overridden

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-12-04 Thread via GitHub
o-nikolas commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1839334031 Thanks for taking the time to read and consider this issue @ferruzzi, it's a sticky one and I appreciate the brain cycles. > I think tags should be additive AFAIK i

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-12-04 Thread via GitHub
ferruzzi commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1839359633 > If we go the purely additive approach, it means that there's no way for a task to use executor_config to override the tags provided by the run_task_kwargs config template.

Re: [I] Overriding Additional ECS Task Properties [airflow]

2023-12-04 Thread via GitHub
o-nikolas commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1839391819 > > If we go the purely additive approach, it means that there's no way for a task to use executor_config to override the tags provided by the run_task_kwargs config template.