potiuk closed issue #37971: Scheduler uses [scheduler]job_heartbeat_sec
property for heartbeats instead of [scheduler]scheduler_heartbeat_sec
URL: https://github.com/apache/airflow/issues/37971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985603095
We have a bit of a mess there - because the JOB
(scheduler/job_heartrabeat_sec) has been used and abused by different jobs, so
likely better to keep it in JOB.
--
This is an aut
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985600389
Yeah - I think the way where it is closer to heartrate property is a bit
better and easier to reason about.
--
This is an automated message from the Apache Git Service.
To respond
kosteev commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985591616
I prepared a fix like this https://github.com/apache/airflow/pull/37993
But I see you have already fix (and implemented differently). Should I close
my PR?
--
This is an a
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985565404
(just wanted to make sure how far back it goes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985565030
So it's there since 2.6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985564821
Tracked it down (there were quite a few refactors) and indeed it was #30255
that introduced it
--
This is an automated message from the Apache Git Service.
To respond to the messa
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985546310
Ahh.. those parameters are confusing and I am mixing them ... it is indeed
way older sorry (threshold mixed with secs)
--
This is an automated message from the Apache Git Service.
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985539571
The 2.6.3 version is:
```
def is_alive(self, grace_multiplier=2.1):
"""
Is this job currently alive.
We define alive as in a state
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985536704
@kosteev - are you sure it's affecting 2.6.3 Airflow ? from what I traced
#34026 has been only part of v2-8 branch. Maybe there was another reason before
in 2.6.3 - but quite certa
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985518074
Actually not even there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985513790
I actualy took a quick look and it turned out that it was removed after
adding SchedulerJobRunner. The SchedulerJob check has been removed by #34026 a
bit later.
I prepared a
kosteev commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985504904
I will try to prepare a fix, but I do not want to commit to this, so that if
anyone wants to fix it.
I will try to work on it today, early next week.
--
This is an automated m
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985472529
> so, now this heartrate: int = conf.getint("scheduler",
"SCHEDULER_HEARTBEAT_SEC") from SchedulerJobRunner is not used anywhere
Indeed.
> "If heartbeat sec is greater
kosteev commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985337125
About reproduction scenario:
"If heartbeat sec is greater than threshold, then yes you'd expect to see
the warning" - yes, but in the scenario you modify [scheduler]job_heartbeat
kosteev commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1985334309
In perform_heartbeat, job.heartrate is used.
The issue is that for scheduler it is defined in SchedulerJobRunner
(previously was SchedulerJob):
https://github.com/apache/airf
potiuk commented on issue #37971:
URL: https://github.com/apache/airflow/issues/37971#issuecomment-1984702476
Are you sure @kosteev ?
From what I see it is used n Job's `perform_heartbeat` method::
```
def perform_heartbeat(
job: Job, heartbeat_callback: Callable[[Se
kosteev opened a new issue, #37971:
URL: https://github.com/apache/airflow/issues/37971
### Apache Airflow version
Other Airflow 2 version (please specify below)
### If "Other Airflow 2 version" selected, which one?
2.6.3
### What happened?
Scheduler uses [s
18 matches
Mail list logo
