vizeit commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911286628
> > @potiuk would re-releasing RC2 include cncf.Kubernetes provider?
@eladkal said in his last comment for my PR #37001 that he will not release rc2
but include it in the next wave.
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911225442
> @potiuk would re-releasing RC2 include cncf.Kubernetes provider? @eladkal
said in his last comment for my PR #37001 that he will not release rc2 but
include it in the next wave. W
vizeit commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911202904
@potiuk would re-releasing RC2 include cncf.Kubernetes provider? @eladkal
said in his last comment for my PR #37001 that he will not release rc2 but
include it in the next wave. Wit
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911145363
@eladkal asked me to take over from here as he is flying tonight. I thought
a bit about it and agree with @Taragolis that reverting #36675 is the best way
to approach this - includi
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1910768076
Then we need to add this fix into the all providers affected by
https://github.com/apache/airflow/pull/36675 (all?) or revert it for now.
Depend on what is faster. In any cases w
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1910279616
> My proposed fix it is just for avoid provide logger_name implicitly even
if it not defined. If we would like to check version than we need to make fixes
in all providers.
I
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909906184
My proposed fix it is just for avoid provide `logger_name` implicitly even
if it not defined. If we would like to check version than we need to make fixes
in all providers.
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909772575
The first approach - the difference in the first case is that you can use
same DAG / Operator for different Airlfow versions. The second one depends on
how you use it - so for exam
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909764632
Or it might be something like that for avoid parsing version
```python
extra_kwargs = {}
if logger_name := kwargs.pop("logger_name", None):
extra_kwargs["logger
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909758045
> I guess this affects only providers which explicitly propagate, something
like super().__init__(logger_name=kwargs.pop("logger_name", None)):
[mongo:
3.6.0rc1](https://pypi
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909695611
- https://github.com/apache/airflow/pull/36851: Check that cloudwatch remote
logger now fallback to the default value even if it not explicitly set, and in
Airflow versions befor
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909664795
- https://github.com/apache/airflow/pull/36675 raise an error in Airflow
versions where `logger_name` not implemented in `LoggingMixin` class
constructor yet
Error which
eladkal commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1909412252
> Yes, this is a new feature
So I will not issue RC2 as this release has many new features that we
shouldnt hold. The fix will be released in the next wave
--
This is an a
vizeit commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908991241
> > Opened #37001 with the fix and unit tested
>
> Cool. Yep. that's ok. In Airlfow `PR` is the `unit of work` - not issue,
issue is mostly advisory and can be missing or ther
flolas commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908966335
Tested
https://github.com/apache/airflow/issues/36948#:~:text=Implement%20AthenaSQLHook%20(%2336171).
Work as expected.
Env: Amazon MWAA [v2.7.2](https://pypi.python.org/py
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908944188
> Opened https://github.com/apache/airflow/pull/37001 with the fix and unit
tested
Cool. Yep. that's ok. In Airlfow `PR` is the `unit of work` - not issue,
issue is mostly ad
vizeit commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908937247
> #36922 tested. It is working for configmaps mounted as volume but not for
configmaps mounted as environment variable. I was troubleshooting the issue and
it appears that I will ne
vizeit commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908637320
#36922 tested. It is working for configmaps mounted as volume but not for
configmaps mounted as environment variable. I was troubleshooting the issue and
it appears that I will need
hussein-awala commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908431833
Tested my changes, they look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
renzepost commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1908146019
#36817 works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
Lee-W commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1907775136
Tested https://github.com/apache/airflow/pull/36586,
https://github.com/apache/airflow/pull/36578,
https://github.com/apache/airflow/pull/36550,
https://github.com/apache/airflow/pu
AchimGaedkeLynker commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1907641660
https://github.com/apache/airflow/pull/36828 works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
moiseenkov commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1907634824
#36276 works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
VladaZakharova commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1907633506
Hi!
#36473 works as well, thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
romsharon98 commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1907625589
Validate changes in:
https://github.com/apache/airflow/pull/36911
https://github.com/apache/airflow/pull/36905
https://github.com/apache/airflow/pull/36663
https://gi
Taragolis commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1906532785
Validate changes in
- https://github.com/apache/airflow/pull/36831
- https://github.com/apache/airflow/pull/36834
- https://github.com/apache/airflow/pull/36818
- http
potiuk commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1906259070
All my changes work ! :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Lee-W commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1905855808
Verified https://github.com/apache/airflow/pull/36892,
https://github.com/apache/airflow/pull/36946 and
https://github.com/apache/airflow/pull/36894. will continue work on the rest
arjunanan6 commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1905521441
Test #36752 and it works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
m1racoli commented on issue #36948:
URL: https://github.com/apache/airflow/issues/36948#issuecomment-1904316688
Tested https://github.com/apache/airflow/pull/36861 and impersonation chain
is now properly passed.
--
This is an automated message from the Apache Git Service.
To respond to th
eladkal opened a new issue, #36948:
URL: https://github.com/apache/airflow/issues/36948
### Body
I have a kind request for all the contributors to the latest provider
packages release.
Could you please help us to test the RC versions of the providers?
The guidelines on how t
31 matches
Mail list logo
