Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-08 Thread via GitHub
vincbeck merged PR #35312: URL: https://github.com/apache/airflow/pull/35312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-08 Thread via GitHub
mhenc commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1801430231 Finally I made the tests green. There were some changes required. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1798472770 BTW. Fix to failing "Skip Build" in https://github.com/apache/airflow/pull/35503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-02 Thread via GitHub
potiuk commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1791453017 Some tests are failing though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-02 Thread via GitHub
hussein-awala commented on code in PR #35312: URL: https://github.com/apache/airflow/pull/35312#discussion_r1380678723 ## airflow/models/dagrun.py: ## @@ -466,7 +467,7 @@ def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str: def fetch_task_instances(

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-02 Thread via GitHub
vincbeck commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1790797063 There are some circular dependency issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-02 Thread via GitHub
mhenc commented on code in PR #35312: URL: https://github.com/apache/airflow/pull/35312#discussion_r1379987451 ## airflow/api/common/experimental/get_task_instance.py: ## @@ -42,5 +42,6 @@ def get_task_instance(dag_id: str, task_id: str, execution_date: datetime) -> Ta if

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-11-01 Thread via GitHub
vincbeck commented on code in PR #35312: URL: https://github.com/apache/airflow/pull/35312#discussion_r1378727439 ## airflow/models/dagrun.py: ## @@ -466,7 +467,7 @@ def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str: def fetch_task_instances(

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-10-31 Thread via GitHub
hussein-awala commented on code in PR #35312: URL: https://github.com/apache/airflow/pull/35312#discussion_r1378253597 ## airflow/api/common/experimental/get_task_instance.py: ## @@ -42,5 +42,6 @@ def get_task_instance(dag_id: str, task_id: str, execution_date: datetime) -> Ta

Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-10-31 Thread via GitHub
mhenc commented on PR #35312: URL: https://github.com/apache/airflow/pull/35312#issuecomment-1788068521 cc: @potiuk @vincbeck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

2023-10-31 Thread via GitHub
mhenc opened a new pull request, #35312: URL: https://github.com/apache/airflow/pull/35312 Change TaskCommand._get_ti to return either TaskInstance or TaskInstancePydantic, making sure it calls the InternalAPI in dbless mode. Some CLI commands, despite calling TaskCommand._get_ti stil