[PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-19 Thread via GitHub
maycuatroi opened a new pull request, #38299: URL: https://github.com/apache/airflow/pull/38299 # Description I've added a configuration option `require_confirmation_dag_change` to both the `config.yml` and the Flask App. Its default value is `False`. However, when a user sets this c

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-19 Thread via GitHub
boring-cyborg[bot] commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2007983167 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-19 Thread via GitHub
maycuatroi commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2008576733 @hussein-awala I've fixed the static check issue. Thank you for your advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-20 Thread via GitHub
maycuatroi commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2009431814 @potiuk sorry for taking your time. I'm fixed the ruff check. Please approve trigger the workflow to run test. 🙆‍♂️ -- This is an automated message from the Apache Git Service

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-20 Thread via GitHub
hussein-awala merged PR #38299: URL: https://github.com/apache/airflow/pull/38299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-20 Thread via GitHub
boring-cyborg[bot] commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2009739765 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-03-20 Thread via GitHub
hussein-awala commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2009741163 Congrats on your first commit 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-05-16 Thread via GitHub
xjchew commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2114716172 May I suggest that this be added to `dags.html` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production [airflow]

2024-05-17 Thread via GitHub
maycuatroi commented on PR #38299: URL: https://github.com/apache/airflow/pull/38299#issuecomment-2117698205 > May I suggest that this be added to `dags.html` as well? `dags.html` is the Dags list screen. I believe this change is necessary, and I'll create a PR to update it. --