Re: [PR] [POC] Standardize deprecations in Airflow [airflow]

2024-01-18 Thread via GitHub
kacpermuda commented on code in PR #36876: URL: https://github.com/apache/airflow/pull/36876#discussion_r1458507297 ## airflow/deprecation.py: ## Review Comment: The idea i wanted to discuss is if we should move all deprecation related Warnings and decorators into a separa

Re: [PR] [POC] Standardize deprecations in Airflow [airflow]

2024-01-18 Thread via GitHub
kacpermuda commented on code in PR #36876: URL: https://github.com/apache/airflow/pull/36876#discussion_r1458504663 ## airflow/providers/google/cloud/links/dataproc.py: ## @@ -71,13 +70,16 @@ def __getattr__(name: str) -> Any: ) -@attr.s(auto_attribs=True) +@deprecated( +

Re: [PR] [POC] Standardize deprecations in Airflow [airflow]

2024-01-18 Thread via GitHub
Taragolis commented on code in PR #36876: URL: https://github.com/apache/airflow/pull/36876#discussion_r1457894304 ## airflow/providers/google/cloud/links/dataproc.py: ## @@ -71,13 +70,16 @@ def __getattr__(name: str) -> Any: ) -@attr.s(auto_attribs=True) +@deprecated( +

[PR] [POC] Standardize deprecations in Airflow [airflow]

2024-01-18 Thread via GitHub
kacpermuda opened a new pull request, #36876: URL: https://github.com/apache/airflow/pull/36876 ## TLDR; I propose standardizing our approach to deprecating elements in the Airflow codebase, aiming for improved readability and easier automated parsing. This PR serves as a for