Taragolis commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942861919
One of the possible reason changes in collection order:
https://github.com/pytest-dev/pytest/issues/
Other changes in pytest 8: https://docs.pytest.org/en/stable/changelog.h
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942578276
Or smth equally racy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942577285
> It seems to work with this, which is more strange to me 🤔 Let's wait for
the CI
Ah - interesting, that would mean that the default logging configuration is
not initialized the
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942562930
> Try to add format which include `asctime` attribute into format into the
formatter
>
>
https://github.com/apache/airflow/blob/1aa91a482630f389005a9a36b0f038e675163411/tes
Taragolis commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942542652
Try to add format which include `asctime` attribute into format into the
formatter
https://github.com/apache/airflow/blob/1aa91a482630f389005a9a36b0f038e675163411/tests/utils/log/t
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942490184
This one is strange :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1942396055
yes, I tried that too, but it didn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1940166577
@hussein-awala : change patching:
`airflow.utils.log.timezone_aware.TimezoneAware.formatTime` ->
`airflow.utils.log.colored_log.TimezoneAware.formatTime` ?
--
This is an automated me
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1939996320
I'm still trying to understand why
`tests/utils/log/test_colored_log.py::test_format_time_uses_tz_aware` fails in
Breeze the first time I run it, but it works locally and in Breez
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1937815633
Thanks Jarek for this detailed explanation and for the tip to test the
future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1937771054
For the future @hussein-awala -
One easy way to test if a new dependency is not conflicting is quite simple:
1) Update pyproject toml
2) Enter Breeze
3) Run `pip instal
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1937768088
PR removing pytest-httpx here: https://github.com/apache/airflow/pull/37334
- once we merge it , we can try again.
--
This is an automated message from the Apache Git Service.
To respo
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1937762641
There is a exactly 1(!) test that uses `httpx_mock` - so I think we should
remove `pytest-httpx` and implement the test differently
test_info_command.py:
```python
de
potiuk commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1937762132
Hey @hussein-awala -> the big problem is pytest-httpx. The latest version we
can install in Python 3.8 is 0.23.1 (0.24 and above is Python >= 3.9. The
0.23.1 has Pytest < 8 so `pip` simp
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1935092207
It will be fixed in the next release
https://github.com/pytest-dev/pytest-asyncio/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the messa
hussein-awala commented on PR #37151:
URL: https://github.com/apache/airflow/pull/37151#issuecomment-1924628015
depends on: https://github.com/pytest-dev/pytest-asyncio/pull/765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hussein-awala opened a new pull request, #37151:
URL: https://github.com/apache/airflow/pull/37151
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
17 matches
Mail list logo
