Lee-W commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2412632998
> The obvious solution"is to add a context parameter to the callback
function. However, this would change the method signature and potentially break
code somewhere "in the wild". I highly
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2411751647
I suppose for 1-argument callbacks we could catch the type error, print a
warning to update the function, and then call it with just the message. Is
generating the TypeError expensive
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2411644710
I might have messed this one up from a usability point of view. I was
assuming that if the context was needed in the callback it could be captured in
a lambda and passed down. However
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2330269872
Thank you @potiuk and @Lee-W.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
potiuk commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1744585720
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +342,32 @@ def receive_subscription_message(
max_message_count=max_message_count,
max
perry2of5 commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1744584448
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +342,32 @@ def receive_subscription_message(
max_message_count=max_message_count,
potiuk commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1744565440
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +342,32 @@ def receive_subscription_message(
max_message_count=max_message_count,
max
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2329917131
This is ready to be reviewed again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
perry2of5 commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1738975370
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +336,27 @@ def receive_subscription_message(
max_message_count=max_message_count,
perry2of5 commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1738925961
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +336,27 @@ def receive_subscription_message(
max_message_count=max_message_count,
perry2of5 commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1738893954
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +336,27 @@ def receive_subscription_message(
max_message_count=max_message_count,
Lee-W commented on code in PR #41601:
URL: https://github.com/apache/airflow/pull/41601#discussion_r1738376359
##
airflow/providers/microsoft/azure/hooks/asb.py:
##
@@ -326,5 +336,27 @@ def receive_subscription_message(
max_message_count=max_message_count,
max_
Lee-W commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2320763837
> For my particular use case, I want to grab a file-location URL out of the
message body and pass it to the next task in the DAG. In general, it provides a
way to receive data from the me
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2315811790
For my particular use case, I want to grab a file-location URL out of the
message body and pass it to the next task in the DAG. In general, it provides a
way to receive data from the
Lee-W commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2314777532
It looks good at the first glance but would like to know what would be the
main usage of this functionality
--
This is an automated message from the Apache Git Service.
To respond to th
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2307866016
Any chance @Lee-W or @Taragolis can review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
perry2of5 commented on PR #41601:
URL: https://github.com/apache/airflow/pull/41601#issuecomment-2299839998
This addresses https://github.com/apache/airflow/discussions/26446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
perry2of5 opened a new pull request, #41601:
URL: https://github.com/apache/airflow/pull/41601
This PR adds a callback to process messages from an Azure Service Bus.
Right now, on main, the Azure Service Bus message receiver simply logs the
messages received and returns. This PR pres
18 matches
Mail list logo
