Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-09-02 Thread via GitHub
potiuk merged PR #41576: URL: https://github.com/apache/airflow/pull/41576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-09-02 Thread via GitHub
moiseenkov commented on PR #41576: URL: https://github.com/apache/airflow/pull/41576#issuecomment-2324601110 > Looks good overall! > I got a small comment regarding reusability. @shahar1 , Thanks for the review. Please take a look at the fixes. -- This is an automated message

Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-09-02 Thread via GitHub
moiseenkov commented on code in PR #41576: URL: https://github.com/apache/airflow/pull/41576#discussion_r1740803481 ## airflow/providers/google/cloud/operators/dataflow.py: ## @@ -945,6 +948,11 @@ def on_kill(self) -> None: ) +@deprecated( +reason="DataflowS

Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-09-02 Thread via GitHub
moiseenkov commented on code in PR #41576: URL: https://github.com/apache/airflow/pull/41576#discussion_r1740803070 ## airflow/providers/google/cloud/hooks/dataflow.py: ## @@ -938,6 +937,110 @@ def launch_job_with_flex_template( response: dict = request.execute(num_retr

Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-08-22 Thread via GitHub
shahar1 commented on code in PR #41576: URL: https://github.com/apache/airflow/pull/41576#discussion_r1726678936 ## airflow/providers/google/cloud/hooks/dataflow.py: ## @@ -938,6 +937,110 @@ def launch_job_with_flex_template( response: dict = request.execute(num_retries

Re: [PR] Add DataflowStartYamlJobOperator [airflow]

2024-08-22 Thread via GitHub
shahar1 commented on code in PR #41576: URL: https://github.com/apache/airflow/pull/41576#discussion_r1726678936 ## airflow/providers/google/cloud/hooks/dataflow.py: ## @@ -938,6 +937,110 @@ def launch_job_with_flex_template( response: dict = request.execute(num_retries

[PR] Add DataflowStartYamlJobOperator [airflow]

2024-08-19 Thread via GitHub
moiseenkov opened a new pull request, #41576: URL: https://github.com/apache/airflow/pull/41576 Add DataflowStartYamlJobOperator as a replacement option for DataflowStartSqlJobOperator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t