pateash commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1778986522
Hi @cjames23,
Just a quick question regarding this one.
as we know OpenSearch is just a fork of Elasticsearch which happened couple
of years ago,
Can we not use Elastic search
ferruzzi commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1765090521
Nice, congrats!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
eladkal commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1763467597
🎉 🎉 🎉 🎉 🎉 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
eladkal merged PR #34705:
URL: https://github.com/apache/airflow/pull/34705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
potiuk commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1763123380
Fixed https://github.com/apache/airflow/pull/34941 and few other issues that
caused broken main. Rebasing/resolving conflicts (generally regenerating breeze
images with. `breeze setup re
eladkal commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1763061002
> If the checks fail after this merge from main do you want me to include
any fixes here for the breeze mypy issue? I think it just needs to be changed
from ignore[misc] to ignore[attr-
cjames23 commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1762995522
If the checks fail after this merge from main do you want me to include any
fixes here for the breeze mypy issue? I think it just needs to be changed from
ignore[misc] to ignore[attr-d
ferruzzi commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1762208402
What an odd static check to fail, I can't see how it could be related. I'm
going to bump it and see if it was just flake. If it fails again, we'll have
to sort it out.
--
This i
cjames23 commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1760864875
> Yeah, I saw that, but the only changes in the Amazon package were some
whitespace and punctuation in a docstring. Better done separate, but I didn't
think it was worth blocking over
cjames23 commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1760851926
@eladkal any advice on the failure that is happening with the CI image build
step and the static checks? I ran breeze static checks against all files
locally and do not receive the sam
cjames23 commented on code in PR #34705:
URL: https://github.com/apache/airflow/pull/34705#discussion_r1357592192
##
airflow/providers/opensearch/hooks/opensearch.py:
##
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lic
eladkal commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1755950688
> Yeah, I saw that, but the only changes in the Amazon package were some
whitespace and punctuation in a docstring. Better done separate, but I didn't
think it was worth blocking over i
ferruzzi commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1755924053
Yeah, I saw that, but the only changes in the Amazon package were some
whitespace and punctuation in a docstring. Better done separate, but I didn't
think it was worth blocking over
eladkal commented on PR #34705:
URL: https://github.com/apache/airflow/pull/34705#issuecomment-1752744510
Just to clarify - This PR suppose to be only open search provider related
code and https://github.com/apache/airflow/pull/34693 should be a followup with
additional integrations for ope
14 matches
Mail list logo
