potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1934429625
Usually the real work starts after it gets in the hands of the users :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Anush008 commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1934310475
Thanks @potiuk, @eladkal for supporting this 🙏🙏.
Do let me know if there's anything else needed.
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1934182852
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
boring-cyborg[bot] commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1934182542
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
potiuk merged PR #36805:
URL: https://github.com/apache/airflow/pull/36805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1934179481
FINALLY GREEN !!!.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1924429953
It's problem with Airflow - 2.6 has problem with Pydantic 1(that's why you
need to limit it. That's why you cannot install qdrant on it. As of 2.7
airflwo supports both an d in 2.8. on
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1924415290
It's problem with Airflow - 2.6 has problem with Pydantic 1(that's why you
need to limit it. That's why you cannot install qdrant on it. As of 2.7
airflwo supports both an d in 2.8. on
Anush008 commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1924328621
Hey.
> the compatibility checks detected, that your provider requires Pydantic 2
by, which is not supported in `Airflow 2.6.*`.
`qdrant_client` uses Pydantic v1. The fail
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1923706786
FYI: @Anush008 :
You will have to make your provider compatible with Airflow 2.7.0+ the
compatibility checks detected, that your provider requires Pydantic 2 by, which
is not su
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1475763053
##
airflow/providers/qdrant/hooks/qdrant.py:
##
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
eladkal commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1475758927
##
airflow/providers/qdrant/hooks/qdrant.py:
##
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1470662843
##
pyproject.toml:
##
@@ -533,6 +533,7 @@ alibaba = [
"oss2>=2.14.0",
]
amazon = [
+ "PyAthena>=3.0.10",
Review Comment:
It came in with one of the merge c
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1470662469
##
tests/providers/qdrant/operators/test_qdrant.py:
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
josh-fell commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1470517045
##
pyproject.toml:
##
@@ -533,6 +533,7 @@ alibaba = [
"oss2>=2.14.0",
]
amazon = [
+ "PyAthena>=3.0.10",
Review Comment:
Is this a related change?
potiuk commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1912417454
Ah... Now ... after I refactored the contributing guide - there you need to
solve conflicts move things around I am afraid :( .. sorry for that @Anush008
--
This is an automated mess
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1465924336
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
potiuk commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1465430866
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor l
potiuk commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1465429667
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor l
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464513380
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464513380
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464513380
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464513380
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464507774
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
eladkal commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464499920
##
docs/apache-airflow-providers-qdrant/connections.rst:
##
@@ -0,0 +1,58 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464259038
##
airflow/providers/qdrant/provider.yaml:
##
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
potiuk commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1464161830
##
airflow/providers/qdrant/provider.yaml:
##
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
Anush008 commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1902053348
> I think that some of the hook tests are not needed since there is no
wrapper for the client methods in the hook, you call them from the client and
you check if they are called. Same
Anush008 commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1460338964
##
airflow/providers/qdrant/hooks/qdrant.py:
##
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
hussein-awala commented on code in PR #36805:
URL: https://github.com/apache/airflow/pull/36805#discussion_r1460322493
##
airflow/providers/qdrant/hooks/qdrant.py:
##
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
boring-cyborg[bot] commented on PR #36805:
URL: https://github.com/apache/airflow/pull/36805#issuecomment-1893144526
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
Anush008 opened a new pull request, #36805:
URL: https://github.com/apache/airflow/pull/36805
This PR intends to add Qdrant as a supported provider.
[Qdrant](https://qdrant.tech/) is an open-source, Apache-licensed, vector
search engine and database.
The PR adds a Qdrant operat
32 matches
Mail list logo
