Re: [PR] Add TabularVttsSensor [airflow]

2024-07-05 Thread via GitHub
github-actions[bot] closed pull request #39091: Add TabularVttsSensor URL: https://github.com/apache/airflow/pull/39091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Add TabularVttsSensor [airflow]

2024-07-02 Thread via GitHub
github-actions[bot] commented on PR #39091: URL: https://github.com/apache/airflow/pull/39091#issuecomment-2197788855 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Add TabularVttsSensor [airflow]

2024-05-12 Thread via GitHub
eladkal commented on PR #39091: URL: https://github.com/apache/airflow/pull/39091#issuecomment-2106353168 @Fokko We can now resume this PR on the iceberg provider rather than tabular -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add TabularVttsSensor [airflow]

2024-04-17 Thread via GitHub
Fokko commented on PR #39091: URL: https://github.com/apache/airflow/pull/39091#issuecomment-2062008913 @eladkal Yes, it is called the `TabularVttsSensor`, but it doesn't have anything Tabular specific, it is fully Iceberg OSS compatible. -- This is an automated message from the Apache Gi

Re: [PR] Add TabularVttsSensor [airflow]

2024-04-17 Thread via GitHub
eladkal commented on PR #39091: URL: https://github.com/apache/airflow/pull/39091#issuecomment-2061874665 Do we want to add this before the creation of iceberg provider ? because it means adding class that we will deprecate (soon?) https://github.com/apache/airflow/pull/32786#issuecomment

Re: [PR] Add TabularVttsSensor [airflow]

2023-12-24 Thread via GitHub
github-actions[bot] closed pull request #32786: Add TabularVttsSensor URL: https://github.com/apache/airflow/pull/32786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Add TabularVttsSensor [airflow]

2023-12-12 Thread via GitHub
github-actions[bot] commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1853061371 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-28 Thread via GitHub
eladkal commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1783760017 > We should likely do it before we release the changes from this PR (cc: @eladkal ) Then we should have separated PR that creates iceberg provider move all logic from tabular to

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1768539718 I just reserved names for it BTW . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1768531350 > @bolkedebruin You're right, in hindsight this could have been Iceberg instead of Tabular. As discussed before with @Fokko we can /should rename it to Iceberg provider. We have a

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-18 Thread via GitHub
Fokko commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1768284013 @bolkedebruin You're right, in hindsight this could have been Iceberg instead of Tabular. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-18 Thread via GitHub
bolkedebruin commented on PR #32786: URL: https://github.com/apache/airflow/pull/32786#issuecomment-1768191334 Just wondering why we call this the Tabular(Provider/Hook/Sensor). It seems to me that this is more generic and not specific to Tabular. Iceberg might make more sense? -- This i

Re: [PR] Add TabularVttsSensor [airflow]

2023-10-17 Thread via GitHub
Fokko commented on code in PR #32786: URL: https://github.com/apache/airflow/pull/32786#discussion_r1362663092 ## airflow/utils/db.py: ## @@ -644,7 +644,7 @@ def create_default_connections(session: Session = NEW_SESSION): Connection( conn_id="tabular_defau