gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802186567
@potiuk do you have any ideas on how it would fit into `BaseOperator`?
Because I can only think about something like `templateable_fields` (the exact
naming isn't important at the mome
hussein-awala commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802749813
@gdavoian I agree with Jarek.
This PR was created to avoid the rendering issues with BaseOperator
attributes like `execution_timeout`.
IMHO, you can create a test tha
gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802865640
> This PR was created to avoid the rendering issues with BaseOperator
attributes like execution_timeout.
But how does this PR help solve the rendering issue? I understand that it
potiuk commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802925162
@gdavoidan - what I proposed and I believe @hussein-awala agrees with is
that you define which fields of BaseOperator you exclude from the check. This
is what my proposal is about. Find
hussein-awala commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802930988
> But how does this PR help solve the rendering issue?
Most of these attributes should not be used as a templated field, so the PR
helped quickly fail the dag parsing instea
gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802995760
@potiuk @hussein-awala Thank you for the explanations. I'm starting to
understand the problem and what I need to do. I'll check and get back to you
soon. My apologies for any earlier m
potiuk commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1802998230
> @potiuk @hussein-awala Thank you for the explanations! I'm starting to
understand the problem and what I'm supposed to do. I'll check and get back to
you soon. My apologies for any ear
gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1803354795
Hm, you were right, looks like only `email` is a field that is 100% safe to
template (as I mentioned before, the field is heavily used by our team as
`default_args["email"]` for each a
potiuk commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1803386889
> Hm, you were right, looks like only `email` is a field that is 100% safe
to template (as I mentioned before, the field is heavily used by our team as
`default_args["email"]` for each a
gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-180313
@potiuk @hussein-awala You're welcome to review
https://github.com/apache/airflow/pull/35546 :)
--
This is an automated message from the Apache Git Service.
To respond to the message
gdavoian commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1795037963
@hussein-awala Unfortunately, this change is going to break our Airflow
environment.
Is there any reason why `BaseOperator.email` can't be templated? E.g., we
store different e
potiuk commented on PR #29821:
URL: https://github.com/apache/airflow/pull/29821#issuecomment-1795509731
I think that's a good idea to make a PR to exclude some of the fields in
this way. I think PR for that would be good @gdavoian
--
This is an automated message from the Apache Git Serv
12 matches
Mail list logo
