[PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-13 Thread via GitHub
hussein-awala opened a new pull request, #35616: URL: https://github.com/apache/airflow/pull/35616 For security reasons, using "0.0.0.0" as a host is not a good practice, even for a health check server. This PR creates a new config to configure the host of the scheduler health check

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-13 Thread via GitHub
potiuk commented on code in PR #35616: URL: https://github.com/apache/airflow/pull/35616#discussion_r1391786285 ## airflow/config_templates/config.yml: ## @@ -2130,6 +2130,14 @@ scheduler: type: boolean example: ~ default: "False" +scheduler_health_check

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-13 Thread via GitHub
potiuk commented on PR #35616: URL: https://github.com/apache/airflow/pull/35616#issuecomment-1809260644 (and nice bandit to tell us so - BTW :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-14 Thread via GitHub
hussein-awala commented on code in PR #35616: URL: https://github.com/apache/airflow/pull/35616#discussion_r1393047898 ## airflow/config_templates/config.yml: ## @@ -2130,6 +2130,14 @@ scheduler: type: boolean example: ~ default: "False" +scheduler_healt

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-14 Thread via GitHub
potiuk commented on code in PR #35616: URL: https://github.com/apache/airflow/pull/35616#discussion_r1393094643 ## airflow/config_templates/config.yml: ## @@ -2130,6 +2130,14 @@ scheduler: type: boolean example: ~ default: "False" +scheduler_health_check

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-14 Thread via GitHub
potiuk commented on code in PR #35616: URL: https://github.com/apache/airflow/pull/35616#discussion_r1393094986 ## airflow/config_templates/config.yml: ## @@ -2130,6 +2130,14 @@ scheduler: type: boolean example: ~ default: "False" +scheduler_health_check

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-25 Thread via GitHub
hussein-awala commented on PR #35616: URL: https://github.com/apache/airflow/pull/35616#issuecomment-1826412613 Static checks failure is not related to this PR; I will try to fix it in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

2023-11-25 Thread via GitHub
hussein-awala merged PR #35616: URL: https://github.com/apache/airflow/pull/35616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai