[PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
guydriesen opened a new pull request, #39464: URL: https://github.com/apache/airflow/pull/39464 This PR adds the support for defining arguments to the DockerSwarmOperator. The currently available command option replaces the entrypoint on a docker service container, with the args you c

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
Taragolis commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1592797003 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) la

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1592822375 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) l

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1592822375 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) l

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1592835583 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) l

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
dirrao commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593293779 ## tests/providers/docker/operators/test_docker_swarm.py: ## @@ -254,3 +255,41 @@ def test_container_resources(self, types_mock, docker_api_client_patcher):

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-07 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593454225 ## tests/providers/docker/operators/test_docker_swarm.py: ## @@ -254,3 +255,41 @@ def test_container_resources(self, types_mock, docker_api_client_patcher):

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-08 Thread via GitHub
Taragolis commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593491332 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) la

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-08 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593856057 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) l

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-08 Thread via GitHub
Taragolis commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593883440 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) la

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-08 Thread via GitHub
guydriesen commented on code in PR #39464: URL: https://github.com/apache/airflow/pull/39464#discussion_r1593969669 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -225,6 +231,24 @@ def stream_new_logs(last_line_logged, since=0): sleep(2) l

Re: [PR] Add args to docker service ContainerSpec [airflow]

2024-05-17 Thread via GitHub
Taragolis merged PR #39464: URL: https://github.com/apache/airflow/pull/39464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo