Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-08 Thread via GitHub
jscheffl merged PR #37985: URL: https://github.com/apache/airflow/pull/37985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-08 Thread via GitHub
jscheffl commented on PR #37985: URL: https://github.com/apache/airflow/pull/37985#issuecomment-1986348759 Sorry that I needed re-work a bit - I needed to realize that the `ansi_up` does only handle the URLyfication only for ANSI encoded URLs, not plain text URLs. So needed to roll-back a b

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-08 Thread via GitHub
potiuk commented on code in PR #37985: URL: https://github.com/apache/airflow/pull/37985#discussion_r1517653733 ## airflow/www/jest.config.js: ## @@ -32,6 +32,7 @@ const config = { transformIgnorePatterns: [ `node_modules/(?!${[ // specify modules that needs to be

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-08 Thread via GitHub
jscheffl commented on PR #37985: URL: https://github.com/apache/airflow/pull/37985#issuecomment-1985583083 Oh, wow 12 approvals in <12h :-D I found one glitch with the re-work, please do not merge (yet), need to fix this in the afternoon so that the linkify is working again. -- This is

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-07 Thread via GitHub
potiuk commented on PR #37985: URL: https://github.com/apache/airflow/pull/37985#issuecomment-1985115939 > I just realized that the "new" integrated lib also can take care of HTML escaping and URLifying, that will be an option to clean custom code. Oh wow. Even better :) -- This is

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-07 Thread via GitHub
jscheffl commented on PR #37985: URL: https://github.com/apache/airflow/pull/37985#issuecomment-1985086177 I just realized that the "new" integrated lib also can take care of HTML escaping and URLifying, that will be an option to clean custom code. -- This is an automated message from the

Re: [PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-07 Thread via GitHub
bbovenzi commented on PR #37985: URL: https://github.com/apache/airflow/pull/37985#issuecomment-1984766159 To fix the CI: Can you add the package `"ansi_up"` to the `transformIgnorePatterns` list in `jest.config.js`? -- This is an automated message from the Apache Git Service. To

[PR] Add color formatting for ANSI chars in logs from task executions [airflow]

2024-03-07 Thread via GitHub
jscheffl opened a new pull request, #37985: URL: https://github.com/apache/airflow/pull/37985 We use a lot of colored shell scripts in our environment which always produce ugly log displays in UI... that was bothering me a while already. This PR adds color to log display on UI. Color