Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-30 Thread via GitHub
potiuk merged PR #36483: URL: https://github.com/apache/airflow/pull/36483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-30 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872483058 I will merge it for now - we can always correct it later. I believe the structured way is much cleaner and responds to the "too many details" concern. -- This is an automated message f

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on code in PR #36483: URL: https://github.com/apache/airflow/pull/36483#discussion_r1438414061 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -244,7 +244,7 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once in a

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872241850 Here it is - after employing Chat GPT (after few iterations and discussion with it) and applying the comments above. @BasPH - does it look better ? -- This is an automated message from

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872229139 > https://www.datadoghq.com/dg/monitor/databases/ is great for this kind of monitoring. I am not sure if we should endorse specific services in our docs, but I will leave enough c

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872226453 > > If we can add a feature to automatically clean the data based on the retention parameter that we set in the airflow configuration. > > IMHO, the `db clean` command available in

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872217674 > Great initiative. I have ideas along similar lines. I have observed in our use case where db grows (1GB per day) indefinitely unless manually run the db clean cli command. So, it will

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
hussein-awala commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872189592 > If we can add a feature to automatically clean the data based on the retention parameter that we set in the airflow configuration. IMHO, the `db clean` command available i

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
BasPH commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1872078454 I agree with explaining monitoring of Airflow's meta-database in the docs. However, this chapter contains a lot of (IMO) unnecessary details which makes it difficult to extract the key in

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
jscheffl commented on code in PR #36483: URL: https://github.com/apache/airflow/pull/36483#discussion_r1438203426 ## docs/apache-airflow/howto/set-up-database.rst: ## @@ -383,6 +383,69 @@ After configuring the database and connecting to it in Airflow configuration, yo ai

Re: [PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk commented on PR #36483: URL: https://github.com/apache/airflow/pull/36483#issuecomment-1871984595 Inspired by discussion in https://github.com/apache/airflow/discussions/36454 - whenever user/issue is likely related to excessive DB usage, we should be able to just link the discussio

[PR] Add description on the ways how users should approach DB monitoring [airflow]

2023-12-29 Thread via GitHub
potiuk opened a new pull request, #36483: URL: https://github.com/apache/airflow/pull/36483 Often our users are not aware that they are responsible for setting up and monitoring the database they chose as the metaa-data backend. While details of the tables and database structure of th