kacpermuda opened a new pull request, #37075:
URL: https://github.com/apache/airflow/pull/37075
## TLDR
I want to add a documentation page that will have all the deprecated
classes, methods, functions etc. It will get more information when #36876 is
merged (where i switched a
eladkal commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469966259
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more co
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469989464
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
Ah, this will be needed when #36876 is merged (soo
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469991675
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469992933
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
eladkal commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469994293
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
That is odd
I don't think the right fix is to add
eladkal commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1469998144
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more co
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1470777540
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1470781860
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
In the doc page we are providing instructions on w
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1475807282
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1483686305
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more con
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1483686305
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more con
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1483687835
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more con
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1483690075
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
@kacpermuda -> in case of those things that were added
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1483690075
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
@kacpermuda -> in case of those things that were added
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484333085
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
@potiuk That makes sense, I will adjust the class
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484349148
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
Sure - we have docs, we can explain there, also there
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484349148
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
Sure - we have docs, we can explain there, also there
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484349148
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
Sure - we have docs, we can explain there, also there
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484366520
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484435260
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more con
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1484454236
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1486369792
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
I added missing backticks and also adjusted the pr
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1486371298
##
docs/apache-airflow-providers/core-extensions/deprecations.rst:
##
@@ -0,0 +1,57 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more
kacpermuda commented on PR #37075:
URL: https://github.com/apache/airflow/pull/37075#issuecomment-1938939586
@potiuk @eladkal I think this one can be merged if You don't have any
further comments
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
eladkal commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1486715377
##
docs/spelling_wordlist.txt:
##
@@ -122,6 +122,7 @@ avp
Avro
avro
aws
+AwsBaseAsyncHook
Review Comment:
Nice!
--
This is an automated message from the Ap
eladkal commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1486717103
##
docs/exts/templates/deprecations.rst.jinja2:
##
@@ -0,0 +1,37 @@
+{#
Review Comment:
Question...
is it possible to also have a version of this template per
potiuk commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1486943757
##
docs/exts/templates/deprecations.rst.jinja2:
##
@@ -0,0 +1,37 @@
+{#
Review Comment:
Yeah. This looks like a follow up :)
--
This is an automated message
kacpermuda commented on code in PR #37075:
URL: https://github.com/apache/airflow/pull/37075#discussion_r1487321247
##
docs/exts/templates/deprecations.rst.jinja2:
##
@@ -0,0 +1,37 @@
+{#
Review Comment:
I think it's a great idea. For me, the closer we get to the actual code
mobuchowski merged PR #37075:
URL: https://github.com/apache/airflow/pull/37075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airf
eladkal commented on PR #37075:
URL: https://github.com/apache/airflow/pull/37075#issuecomment-1943899524
Thank you @kacpermuda for this one!
It should really help users to migrate faster to new versions
--
This is an automated message from the Apache Git Service.
To respond to the mes
31 matches
Mail list logo
