Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-04-02 Thread via GitHub
vatsrahul1001 commented on PR #38506: URL: https://github.com/apache/airflow/pull/38506#issuecomment-2031927233 I also agree with @jedcunningham that we should remove 'No options' and only keep `exclude` option rather than having both -- This is an automated message from the Apache Git Se

Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-04-02 Thread via GitHub
phanikumv merged PR #38506: URL: https://github.com/apache/airflow/pull/38506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-04-02 Thread via GitHub
phanikumv commented on PR #38506: URL: https://github.com/apache/airflow/pull/38506#issuecomment-2031425887 > Found a few issues while giving this a spin. > > "No options" - when you first enter into the filter form field, it says there are no options. Even when you start typing say "

Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-03-29 Thread via GitHub
jedcunningham commented on PR #38506: URL: https://github.com/apache/airflow/pull/38506#issuecomment-2027547597 Found a few issues while giving this a spin. "No options" - when you first enter into the filter form field, it says there are no options. Even when you start typing say "ru

Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-03-29 Thread via GitHub
jedcunningham commented on code in PR #38506: URL: https://github.com/apache/airflow/pull/38506#discussion_r1544728878 ## airflow/www/views.py: ## @@ -2782,6 +2782,9 @@ def grid(self, dag_id: str, session: Session = NEW_SESSION): wwwutils.check_import_errors(dag.filelo

Re: [PR] Add exclude/include events filters to audit log [airflow]

2024-03-26 Thread via GitHub
jedcunningham commented on code in PR #38506: URL: https://github.com/apache/airflow/pull/38506#discussion_r1540366990 ## airflow/www/views.py: ## @@ -2782,6 +2782,9 @@ def grid(self, dag_id: str, session: Session = NEW_SESSION): wwwutils.check_import_errors(dag.filelo

[PR] Add exclude/include events filters to audit log [airflow]

2024-03-26 Thread via GitHub
bbovenzi opened a new pull request, #38506: URL: https://github.com/apache/airflow/pull/38506 Add the ability to filter the audit logs by events to include/exclude. Send the config values to the UI to act as the default value. Also, some fixes to the react-select option in the dataset