Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-28 Thread via GitHub
uranusjr merged PR #37708: URL: https://github.com/apache/airflow/pull/37708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-28 Thread via GitHub
uranusjr commented on PR #37708: URL: https://github.com/apache/airflow/pull/37708#issuecomment-1970504486 It’s interesting to me this does not show up in tests that use `rendered_map_index` though. SQLAlchemy is more permissive than I imagined… -- This is an automated message from the Ap

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-27 Thread via GitHub
potiuk commented on PR #37708: URL: https://github.com/apache/airflow/pull/37708#issuecomment-1967459390 Just a watch-out - we have two migrations in-progress. I think we have a protection that will make the secon one not mergable if the first is but there will be some re-work needed once t

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-27 Thread via GitHub
potiuk commented on PR #37708: URL: https://github.com/apache/airflow/pull/37708#issuecomment-1967062774 > Didn't we have a test to ensure migrations and models always build the same db? Wonder when that broke... We never had those. We have a migration test that runs the migration up

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-27 Thread via GitHub
jedcunningham commented on PR #37708: URL: https://github.com/apache/airflow/pull/37708#issuecomment-1966864716 Didn't we have a test to ensure migrations and models always build the same db? Wonder when that broke... -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-26 Thread via GitHub
tirkarthi commented on code in PR #37708: URL: https://github.com/apache/airflow/pull/37708#discussion_r1502995131 ## airflow/migrations/versions/0134_2_9_0_add_rendered_map_index_to_taskinstance.py: ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-26 Thread via GitHub
uranusjr commented on code in PR #37708: URL: https://github.com/apache/airflow/pull/37708#discussion_r1502835166 ## airflow/migrations/versions/0134_2_9_0_add_rendered_map_index_to_taskinstance.py: ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[PR] Add migration for rendered_map_index column in task_instance table. [airflow]

2024-02-26 Thread via GitHub
tirkarthi opened a new pull request, #37708: URL: https://github.com/apache/airflow/pull/37708 Add migration for rendered_map_index column added to task_instance table in PR #36797 related: #36797 -- This is an automated message from the Apache Git Service. To respond to the me