dstandish merged PR #37854:
URL: https://github.com/apache/airflow/pull/37854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
dstandish commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1527915489
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Opti
dstandish commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1527915489
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Opti
dstandish commented on PR #37854:
URL: https://github.com/apache/airflow/pull/37854#issuecomment-2002600741
ok @uranusjr @potiuk @eladkal ...
In response to the question "why do we need to add defaults to pydantic"
I have have added a default of None to attr `task` on TI
dstandish commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1527596385
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Opti
dstandish commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1527591788
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Opti
dstandish commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1527572192
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Opti
potiuk commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r151853
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Optiona
uranusjr commented on code in PR #37854:
URL: https://github.com/apache/airflow/pull/37854#discussion_r1512486165
##
airflow/serialization/pydantic/taskinstance.py:
##
@@ -105,12 +105,13 @@ class TaskInstancePydantic(BaseModelPydantic,
LoggingMixin):
trigger_timeout: Optio
dstandish opened a new pull request, #37854:
URL: https://github.com/apache/airflow/pull/37854
One was wrong type, others were missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
10 matches
Mail list logo