eladkal merged PR #34669:
URL: https://github.com/apache/airflow/pull/34669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #34669:
URL: https://github.com/apache/airflow/pull/34669#issuecomment-1792797128
Anyone else ? It looks pretty good for merging :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Joffreybvn commented on code in PR #34669:
URL: https://github.com/apache/airflow/pull/34669#discussion_r1381642943
##
airflow/operators/__init__.py:
##
@@ -90,6 +90,7 @@
"HiveToSambaOperator":
potiuk commented on code in PR #34669:
URL: https://github.com/apache/airflow/pull/34669#discussion_r1379713447
##
airflow/operators/__init__.py:
##
@@ -90,6 +90,7 @@
"HiveToSambaOperator":
"airflow.providers.apache.hive.transfers.hive_to_samba.HiveToSambaOperator",
potiuk commented on code in PR #34669:
URL: https://github.com/apache/airflow/pull/34669#discussion_r1379713447
##
airflow/operators/__init__.py:
##
@@ -90,6 +90,7 @@
"HiveToSambaOperator":
"airflow.providers.apache.hive.transfers.hive_to_samba.HiveToSambaOperator",
potiuk commented on PR #34669:
URL: https://github.com/apache/airflow/pull/34669#issuecomment-1790234005
(and yes - removed the milestone- this is "provider only" change and will go
in the next provider release as part of HTTP provider as @eladkal mentioned -
no need to wait for 2.8.0 (and
potiuk commented on code in PR #34669:
URL: https://github.com/apache/airflow/pull/34669#discussion_r1379705858
##
airflow/providers/discord/operators/discord_webhook.py:
##
@@ -77,11 +77,10 @@ def __init__(
self.avatar_url = avatar_url
self.tts = tts
eladkal commented on PR #34669:
URL: https://github.com/apache/airflow/pull/34669#issuecomment-1790016355
> Propose to make this into 2.8.0
This PR is part of peoviders code base thus its not part of Airflow core. In
providers any merged PR is released in following cycle.
--
This
