Re: [PR] Add pagination to `SimpleHttpOperator` and make it more modular [airflow]

2023-10-25 Thread via GitHub
hussein-awala commented on PR #34669: URL: https://github.com/apache/airflow/pull/34669#issuecomment-1778874699 If we decide to implement the feature in the existing operator, I suggest renaming it to `HttpOperator` and creating a deprecated subclass `SimpleHttpOperator` (without any overri

Re: [PR] Add pagination to `SimpleHttpOperator` and make it more modular [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on PR #34669: URL: https://github.com/apache/airflow/pull/34669#issuecomment-1777959720 I implemented back everything into the SimpleHttpOperator, and changed the title. This PR is not about an extra operator anymore, but extending the SimpleHttpOperator. Test should be

Re: [PR] Add pagination to `SimpleHttpOperator` and make it more modular [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on code in PR #34669: URL: https://github.com/apache/airflow/pull/34669#discussion_r1370745878 ## docs/apache-airflow-providers-http/operators.rst: ## @@ -118,3 +118,24 @@ Here we pass form data to a ``POST`` operation which is equal to a usual form su