Nimo139 opened a new pull request, #35704:
URL: https://github.com/apache/airflow/pull/35704
If the SFTP server picks up the file immediately Paramiko cannot check the
file size.
The current operator terminates with a fail after the transfer because the
file cannot be found.
--
T
boring-cyborg[bot] commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1816574318
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
potiuk commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1816589467
I think we will need a (really small) unit test for that one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pankajastro commented on code in PR #35704:
URL: https://github.com/apache/airflow/pull/35704#discussion_r1435631781
##
airflow/providers/google/cloud/transfers/gcs_to_sftp.py:
##
@@ -84,6 +84,7 @@ class GCSToSFTPOperator(BaseOperator):
:param gcp_conn_id: (Optional) The co
eladkal commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1870902651
Hey @Nimo139 do you have time to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Nimo139 commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1880074271
Sorry for the late reply, I didn't have time to set up the test environment
during the holidays. I have now adjusted the tests for the parameter so that
they pass. I have added a very b
potiuk commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1880125333
Should be good enough - now the only thing left is to rebase to latest
`main` and fix failing static checks
--
This is an automated message from the Apache Git Service.
To respond to t
eladkal commented on code in PR #35704:
URL: https://github.com/apache/airflow/pull/35704#discussion_r1444052299
##
tests/providers/google/cloud/transfers/test_gcs_to_sftp.py:
##
@@ -116,7 +116,55 @@ def test_execute_move_single_file(
)
sftp_hook_mock.return_
eladkal commented on code in PR #35704:
URL: https://github.com/apache/airflow/pull/35704#discussion_r1444185999
##
tests/providers/google/cloud/transfers/test_gcs_to_sftp.py:
##
@@ -116,7 +116,55 @@ def test_execute_move_single_file(
)
sftp_hook_mock.return_
eladkal commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1885508551
I fixed the static tests but there is a failure with one of the unit tests
that you need to look into @Nimo139
`FAILED
tests/providers/apache/beam/operators/test_beam.py::TestBeamRu
Nimo139 commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1890798645
Sorry for the force-push, I accidentally updated without clicking the rebase
option. I hope you can still use the PR.
The beam unit test should now pass.
--
This is an automated
eladkal commented on code in PR #35704:
URL: https://github.com/apache/airflow/pull/35704#discussion_r1451660785
##
airflow/providers/apache/beam/operators/beam.py:
##
@@ -522,6 +522,9 @@ def __init__(
)
self.jar = jar
self.job_class = job_class
+
github-actions[bot] commented on PR #35704:
URL: https://github.com/apache/airflow/pull/35704#issuecomment-1970144372
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] closed pull request #35704: Add parameter confirm to
GCSToSFTPOperator
URL: https://github.com/apache/airflow/pull/35704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
14 matches
Mail list logo
