Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1875783224 Cool ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-03 Thread via GitHub
boring-cyborg[bot] commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1875783169 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-03 Thread via GitHub
potiuk merged PR #36497: URL: https://github.com/apache/airflow/pull/36497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-02 Thread via GitHub
potiuk commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1874607563 Some other pre-commits need to be run and fixed :). I highly recomment `pre-commit install` - and then you do not have to even think about it -- This is an automated messag

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-02 Thread via GitHub
potiuk commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1874515361 > Maybe this is what you meant, but would it make sense to create another PR for standardizing breeze.description? > Add a hook, which checks whether breeze.description exists and

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2024-01-02 Thread via GitHub
timonviola commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1874370217 @potiuk Thank's for the feedback, pushed 2 commits, which should cover it. > As a follow-up we could update "version" and "labels" for other files (for airflow service we only

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2023-12-30 Thread via GitHub
potiuk commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1872574142 > Particularly, I am not sure about auto generating the table, as the description part is missing. Could the description be pulled from the yml files? Generally looks cool. We do n

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2023-12-30 Thread via GitHub
timonviola commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1872553584 @potiuk Could you give some first feedback on this? Particularly, I am not sure about **auto generating** the table, as the description part is missing. Could the description b

Re: [PR] Add pre-commit check to check integrations table. [airflow]

2023-12-30 Thread via GitHub
boring-cyborg[bot] commented on PR #36497: URL: https://github.com/apache/airflow/pull/36497#issuecomment-1872552766 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Add pre-commit check to check integrations table. [airflow]

2023-12-30 Thread via GitHub
timonviola opened a new pull request, #36497: URL: https://github.com/apache/airflow/pull/36497 Add pre-commit check to check if integrations and TESTING documentation are synchronized. --- The new pre-commit test: - reads `integration-*.yml` files - reads the table of integr