Re: [PR] Add retries to job heartbeat [airflow]

2024-03-07 Thread via GitHub
boring-cyborg[bot] commented on PR #37541: URL: https://github.com/apache/airflow/pull/37541#issuecomment-1984852695 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Add retries to job heartbeat [airflow]

2024-03-07 Thread via GitHub
potiuk merged PR #37541: URL: https://github.com/apache/airflow/pull/37541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-28 Thread via GitHub
potiuk commented on PR #37541: URL: https://github.com/apache/airflow/pull/37541#issuecomment-1969238346 Anyone :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-26 Thread via GitHub
potiuk commented on PR #37541: URL: https://github.com/apache/airflow/pull/37541#issuecomment-1963925316 I would love to have some more reviews on that one - to see if no-one can see a side effect (I believe it is safe to retry on the level of those methods. -- This is an automated messa

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498378572 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498199155 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498195225 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498189179 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498185263 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
potiuk commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1498179774 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1497904760 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1497904760 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-21 Thread via GitHub
hterik commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1497355952 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1495362690 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
dirrao commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1495225123 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it t

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
boring-cyborg[bot] commented on PR #37541: URL: https://github.com/apache/airflow/pull/37541#issuecomment-1952217336 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
awdavidson opened a new pull request, #37541: URL: https://github.com/apache/airflow/pull/37541 --- Add retries to Job.heartbeat to avoid job SIGTERM due to intermittent/transient database issues. **^ Add meaningful description above** Read the **[Pull R