bolkedebruin merged PR #36410:
URL: https://github.com/apache/airflow/pull/36410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
bolkedebruin commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1877054654
ptal @hussein-awala @potiuk @uranusjr. The doc caching update has been split
from this pr, I've kept the resolution of a `key` relative per examples and
best practices. Integrating
mobuchowski commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1870396524
@bolkedebruin working on it 🙂
https://github.com/apache/airflow/commit/f15a1e01011f1a51fec82d5fcfefa44ba3bc1778
--
This is an automated message from the Apache Git Service.
To res
mobuchowski commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1437100635
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self
bolkedebruin commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1870198238
@mobuchowski if there is any way to *emit* lineage events and openlineage
can reconcile those we can add those events at the lower level so lineage
becomes available for TaskFlow a
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436954455
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436954455
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436951129
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436951129
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436939872
##
docs/apache-airflow/core-concepts/objectstorage.rst:
##
@@ -305,6 +311,27 @@ Airflow needs to walk the directory tree and copy each
file individually. This i
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436939084
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436927983
##
docs/apache-airflow/core-concepts/objectstorage.rst:
##
@@ -305,6 +311,27 @@ Airflow needs to walk the directory tree and copy each
file individually. This i
sour
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436921924
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436922470
##
docs/apache-airflow/core-concepts/objectstorage.rst:
##
@@ -305,6 +311,27 @@ Airflow needs to walk the directory tree and copy each
file individually. This i
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436921924
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436422586
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436422586
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436422586
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436422586
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436422586
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._url
potiuk commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436420411
##
docs/apache-airflow/core-concepts/objectstorage.rst:
##
@@ -305,6 +311,27 @@ Airflow needs to walk the directory tree and copy each
file individually. This i
sour
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436064768
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436064768
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436064768
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
uranusjr commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436030085
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._u
uranusjr commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1436018519
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return self._u
bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1435997508
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
uranusjr commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1868760665
cc @mobuchowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
hussein-awala commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1435889890
##
airflow/io/path.py:
##
@@ -52,6 +52,9 @@ def __init__(
conn_id: str | None = None,
**kwargs: typing.Any,
) -> None:
+# warning
bolkedebruin commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1868580098
should I just add openlineage to the list to 'always' test @potiuk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
bolkedebruin opened a new pull request, #36410:
URL: https://github.com/apache/airflow/pull/36410
This adds low level support for open lineage to ObjectStorage and integrates
it into common.io.
---
**^ Add meaningful description above**
Read the **[Pu
31 matches
Mail list logo
