pankajkoti merged PR #32646:
URL: https://github.com/apache/airflow/pull/32646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airfl
potiuk commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1396066743
##
airflow/jobs/scheduler_job_runner.py:
##
@@ -748,6 +753,17 @@ def _process_executor_events(self, session: Session) ->
int:
ti.pid,
)
dstandish commented on PR #32646:
URL: https://github.com/apache/airflow/pull/32646#issuecomment-1814807709
> The failing test is unrelated and seen in other PRs too. It was reported
here [getmoto/moto#7031
(comment)](https://github.com/getmoto/moto/issues/7031#issuecomment-1814142971)
and
pankajkoti commented on PR #32646:
URL: https://github.com/apache/airflow/pull/32646#issuecomment-1814765776
The failing test is unrelated and seen in other PRs too. It was reported
here https://github.com/getmoto/moto/issues/7031#issuecomment-1814142971 and
likely supposed to get fixed
pankajkoti opened a new pull request, #32646:
URL: https://github.com/apache/airflow/pull/32646
The PR adds a feature by adding the `TaskContextLogger` class that
can forward messages from Airflow components like Scheduler,
Executor, etc to the task logs. This is helpful when in excep
pankajkoti closed pull request #32646: Add task context logging feature to
allow forwarding messages to task logs
URL: https://github.com/apache/airflow/pull/32646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dstandish commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1393418115
##
airflow/models/taskinstance.py:
##
@@ -895,6 +895,19 @@ def refresh_from_db(self, session: Session = NEW_SESSION,
lock_for_update: bool
else:
pankajkoti commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1392786565
##
airflow/utils/log/task_context_logger.py:
##
@@ -0,0 +1,120 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
dstandish commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1392781240
##
airflow/utils/log/task_context_logger.py:
##
@@ -0,0 +1,120 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
phanikumv commented on PR #32646:
URL: https://github.com/apache/airflow/pull/32646#issuecomment-1809581327
@pankajkoti lets implement the pending review comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pankajkoti commented on PR #32646:
URL: https://github.com/apache/airflow/pull/32646#issuecomment-1773009886
> Hey @pankajkoti! We'd love to make use of this feature for the ECS
executor, what's the current standing of this PR?
Hi @o-nikolas , we stalled the story here for a while due
o-nikolas commented on PR #32646:
URL: https://github.com/apache/airflow/pull/32646#issuecomment-1771877671
Hey @pankajkoti! We'd love to make use of this feature for the ECS executor,
what's the current standing of this PR?
--
This is an automated message from the Apache Git Service.
To
12 matches
Mail list logo
