bbovenzi merged PR #40755:
URL: https://github.com/apache/airflow/pull/40755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
bbovenzi commented on code in PR #40755:
URL: https://github.com/apache/airflow/pull/40755#discussion_r1697318774
##
airflow/www/static/js/dag/details/task/AllTaskDuration.tsx:
##
@@ -0,0 +1,167 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
bbovenzi commented on code in PR #40755:
URL: https://github.com/apache/airflow/pull/40755#discussion_r1684510081
##
airflow/www/static/js/dag/details/task/AllTaskDuration.tsx:
##
@@ -0,0 +1,160 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more c
bbovenzi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2236933051
- Consolidating the run and task charts. I think adding an additional
sub-bar which is all the non-task run time would be really helpful for users!
- I love selecting and deselecting
tirkarthi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2236604813
@bbovenzi @ketozhang If someone can also help in fixing the typescript
issue in the PR description moment import that would also help in making the PR
green for further review. I am
tirkarthi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2236599904
> Love the idea of showing task duration even when nothing is selected.
> I'm still partial to a bar chart over a line graph. The discrete task
instance or dag run is more important
tirkarthi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2236582957
It looks easier to implement switching between line and bar chart. In the
latest commit I have added a checkbox similar to "show landing time" in run
duration without persistence to m
tirkarthi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2236537735
> > Clicking on the data point takes the user to specific task instance
detail tab.
>
> ❤️ this. Do you predict the user clicking this would be more interested in
the details t
ketozhang commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2229239814
> Clicking on the data point takes the user to specific task instance detail
tab.
❤️ this. Do you predict the user clicking this would be more interested in
the details tab or
ketozhang commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2229233888
Amongst the suggestion, just want to remind the use case of #40337
> Currently, we can only view the duration of tasks individually, which
makes it difficult to identify spikes
bbovenzi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2228659336
Love the idea of showing task duration even when nothing is selected.
I'm still partial to a bar chart over a line graph. The discrete task
instance or dag run is more important
tirkarthi commented on PR #40755:
URL: https://github.com/apache/airflow/pull/40755#issuecomment-2225997920
Another option that I thought will be cool is a stacked bar chart that shows
the percentage of time each task spent and showing variations. Like a gantt
view of all dagruns but normal
tirkarthi opened a new pull request, #40755:
URL: https://github.com/apache/airflow/pull/40755
closes: #40337
related: #40337
This implements multi-line chart to plot task duration across all dagruns in
the grid. The duration includes only run duration and is stored as seconds.
Du
13 matches
Mail list logo
