Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-08 Thread via GitHub
phanikumv merged PR #37826: URL: https://github.com/apache/airflow/pull/37826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-08 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1517546336 ## airflow/models/dag.py: ## @@ -3032,6 +3034,16 @@ def bulk_sync_to_db( ) return cls.bulk_write_to_db(dags=dags, session=session) +def simpl

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-08 Thread via GitHub
sunank200 commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1517481946 ## airflow/models/dag.py: ## @@ -3115,6 +3119,8 @@ def bulk_write_to_db( ) orm_dag.schedule_interval = dag.schedule_interval

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1517250039 ## airflow/models/dag.py: ## @@ -3115,6 +3119,8 @@ def bulk_write_to_db( ) orm_dag.schedule_interval = dag.schedule_interval o

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
sunank200 commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1517210872 ## tests/api_connexion/endpoints/test_dag_endpoint.py: ## @@ -144,6 +144,36 @@ def _create_dag_model_for_details_endpoint(self, dag_id, session=None): )

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
sunank200 commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1517120911 ## tests/api_connexion/endpoints/test_dag_endpoint.py: ## @@ -144,6 +144,36 @@ def _create_dag_model_for_details_endpoint(self, dag_id, session=None): )

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
bbovenzi commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1516707543 ## tests/api_connexion/endpoints/test_dag_endpoint.py: ## @@ -144,6 +144,36 @@ def _create_dag_model_for_details_endpoint(self, dag_id, session=None): )

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1516602867 ## tests/api_connexion/endpoints/test_dag_endpoint.py: ## @@ -144,6 +144,36 @@ def _create_dag_model_for_details_endpoint(self, dag_id, session=None): )

Re: [PR] Add the dataset_expression as part of DagModel and DAGDetailSchema [airflow]

2024-03-07 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1515936094 ## airflow/models/dag.py: ## @@ -2009,6 +2011,16 @@ def _get_task_instances( return tis +@property +def get_dataset_expression(self) -> Any | No