Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
hussein-awala merged PR #36562: URL: https://github.com/apache/airflow/pull/36562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
hussein-awala commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1876081903 Indeed, I just checked and found that the username argument is accepted in the old versions. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
shohamy7 commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1875913688 @hussein-awala Currently, in the redis provider we are requiring at least `redis>=4.5.2` which support Redis versions 5.0 to 7.0. From the [redis docs](https://redis.io/docs/mana

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
eladkal commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1875807573 >It looks like the client library in the corresponding version can work with redis 6 as specified [here](https://pypi.org/project/redis/#:~:text=om%2Dpython!-,Supported%20Redis%20Versio

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
shohamy7 commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1875731613 I saw this limitation, but this limitation is for the redis client library. It looks like the client library in the corresponding version can work with redis 6 as specified [here](h

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
eladkal commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1875728540 > Redis 6 and above introduced an option to authenticate with username in addition to password. We currently don't support redis 6 due to https://github.com/apache/airflo

[PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
shohamy7 opened a new pull request, #36562: URL: https://github.com/apache/airflow/pull/36562 --- Redis 6 and above introduced an option to authenticate with username in addition to password. This PR aims to add support for this kind of authentication.