ashb commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1699933006
##
airflow/www/views.py:
##
@@ -839,21 +841,92 @@ def index(self):
with create_session() as session:
# read orm_dags from the db
dags_
ashb commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2262715763
(@pruoff And sorry for not noticing the original ping! My GH notifications
are a mess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ashb commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1699925294
##
airflow/www/views.py:
##
@@ -839,21 +841,92 @@ def index(self):
with create_session() as session:
# read orm_dags from the db
dags_
ashb commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1699924198
##
airflow/www/views.py:
##
@@ -839,21 +841,92 @@ def index(self):
with create_session() as session:
# read orm_dags from the db
dags_
ashb commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1699923636
##
airflow/www/views.py:
##
@@ -839,21 +841,92 @@ def index(self):
with create_session() as session:
# read orm_dags from the db
dags_
ashb commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1699922154
##
airflow/www/views.py:
##
@@ -839,21 +841,92 @@ def index(self):
with create_session() as session:
# read orm_dags from the db
dags_
bbovenzi commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2258917527
Looking better! I think we should add an info tooltip telling users the new
keywords search.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2257443570
Here it finally is! I invested many hours in finding the correct methods.
Asking for help did not create any responses neither here nor on Slack. There’s
only one single occurrence of fu
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2130811150
@ashb thanks for the review. I share your concern about resource consumption
issues when loading all dags from the DB.
I tried to query the JSON via many ways. One would be:
`s
jscheffl commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1581455829
##
airflow/www/views.py:
##
@@ -5415,51 +5453,78 @@ class AutocompleteView(AirflowBaseView):
def autocomplete(self, session: Session = NEW_SESSION):
""
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1581435304
##
airflow/www/views.py:
##
@@ -5415,51 +5453,78 @@ class AutocompleteView(AirflowBaseView):
def autocomplete(self, session: Session = NEW_SESSION):
""
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2079612257
> Do we want to include searching by task_display_name in this PR or in a
follow up?
Searching by task_display_name is already included and the PR does not
change this.
--
This
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2076827199
> Let's rebase.
Quite some effort this time. Included the display_dag_name logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jscheffl commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2067295317
@bbovenzi or @eladkal Can yo umake a 2nd pass review, then I thing we should
merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2041956580
> Thanks for the fix, I can confirm it works now as advertised.
>
> I approve from my side. I just kindly request to also alter the
documentation a bit. Else the risk is high that
pruoff commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2041368166
@jscheffl
> I checked and I have no auto-complete and suggestions when I type as
described in the PR descriptions. Tested with Firefox and Chromium. Did I
mis-undertstand the PR that
jscheffl commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2030075088
I checked and I have no auto-complete and suggestions when I type as
described in the PR descriptions. Tested with Firefox and Chromium.
Did I mis-undertstand the PR that suggestions
eladkal commented on PR #37436:
URL: https://github.com/apache/airflow/pull/37436#issuecomment-2029323779
@pruoff can you rebase and resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1496808744
##
airflow/www/static/js/dags.js:
##
@@ -126,16 +126,75 @@ $(".typeahead").typeahead({
success: callback,
});
},
+ matcher(item) {
+const it = th
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1496812864
##
airflow/www/static/js/dags.js:
##
@@ -126,16 +126,75 @@ $(".typeahead").typeahead({
success: callback,
});
},
+ matcher(item) {
+const it = th
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1496812008
##
airflow/www/static/js/dags.js:
##
@@ -126,16 +126,75 @@ $(".typeahead").typeahead({
success: callback,
});
},
+ matcher(item) {
+const it = th
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1496808744
##
airflow/www/static/js/dags.js:
##
@@ -126,16 +126,75 @@ $(".typeahead").typeahead({
success: callback,
});
},
+ matcher(item) {
+const it = th
bbovenzi commented on code in PR #37436:
URL: https://github.com/apache/airflow/pull/37436#discussion_r1496809388
##
airflow/www/static/js/dags.js:
##
@@ -126,16 +126,75 @@ $(".typeahead").typeahead({
success: callback,
});
},
+ matcher(item) {
+const it = th
pruoff opened a new pull request, #37436:
URL: https://github.com/apache/airflow/pull/37436
This PR closes: #37106
Previously the DAG search bar could be used to search by DAG id and owner.
Changes in /home UI from user's perspective:
* DAG search with prefix "task: " filters
24 matches
Mail list logo
