boring-cyborg[bot] commented on PR #40254:
URL: https://github.com/apache/airflow/pull/40254#issuecomment-2249025956
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
bbovenzi merged PR #40254:
URL: https://github.com/apache/airflow/pull/40254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
potiuk commented on PR #40254:
URL: https://github.com/apache/airflow/pull/40254#issuecomment-2246472995
> @potiuk a test that seems to be completely unrelated to these changes is
failing. Any recommendation here?
I re-run it (next time you can do it as well -> top-right `re-run` butt
RNHTTR commented on PR #40254:
URL: https://github.com/apache/airflow/pull/40254#issuecomment-2243742933
@potiuk a test that seems to be completely unrelated to these changes is
failing. Any recommendation here?
--
This is an automated message from the Apache Git Service.
To respond to th
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684914602
##
tests/models/test_xcom_arg_map.py:
##
@@ -188,6 +191,44 @@ def does_not_work_with_c(v):
]
+def test_task_map_from_task_instance_xcom():
Review Comme
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684866921
##
tests/models/test_xcom_arg_map.py:
##
@@ -188,6 +191,44 @@ def does_not_work_with_c(v):
]
+def test_task_map_from_task_instance_xcom():
Review Comme
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684863244
##
tests/models/test_xcom_arg_map.py:
##
@@ -188,6 +191,44 @@ def does_not_work_with_c(v):
]
+def test_task_map_from_task_instance_xcom():
Review Comme
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684814837
##
tests/www/views/test_views_tasks.py:
##
@@ -66,7 +66,7 @@ def reset_dagruns():
@pytest.fixture(autouse=True)
-def init_dagruns(app, reset_dagruns):
Revi
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684814837
##
tests/www/views/test_views_tasks.py:
##
@@ -66,7 +66,7 @@ def reset_dagruns():
@pytest.fixture(autouse=True)
-def init_dagruns(app, reset_dagruns):
Revi
aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1684610001
##
tests/www/views/test_views_tasks.py:
##
@@ -66,7 +66,7 @@ def reset_dagruns():
@pytest.fixture(autouse=True)
-def init_dagruns(app, reset_dagruns):
Review C
andyjianzhou commented on PR #40254:
URL: https://github.com/apache/airflow/pull/40254#issuecomment-2175168777
> You’ll need to revert the whitespace changes, they cause the linter to
fail.
Will do thanks!
--
This is an automated message from the Apache Git Service.
To respond to t
uranusjr commented on PR #40254:
URL: https://github.com/apache/airflow/pull/40254#issuecomment-2175155888
You’ll need to revert the whitespace changes, they cause the linter to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1643694609
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
da
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1643276611
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
da
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1643212674
##
tests/www/test_validators.py:
##
@@ -164,4 +162,4 @@ def setup_method(self):
def test_read_only_validator(self):
validator = validators.ReadOnly
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1643203109
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
da
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1643203109
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
da
aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640919806
##
tests/www/test_validators.py:
##
@@ -164,4 +162,4 @@ def setup_method(self):
def test_read_only_validator(self):
validator = validators.ReadOnly()
aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640919549
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
dateti
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640810107
##
tests/www/views/test_views_grid.py:
##
@@ -514,3 +515,59 @@ def test_next_run_datasets_404(admin_client):
resp = admin_client.get("/object/next_run_datas
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640808886
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
da
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640807897
##
tests/www/views/test_views_grid.py:
##
@@ -514,3 +515,59 @@ def test_next_run_datasets_404(admin_client):
resp = admin_client.get("/object/next_run_datas
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640803190
##
tests/www/test_validators.py:
##
@@ -164,4 +162,4 @@ def setup_method(self):
def test_read_only_validator(self):
validator = validators.ReadOnly
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640800759
##
tests/www/test_validators.py:
##
@@ -164,4 +162,4 @@ def setup_method(self):
def test_read_only_validator(self):
validator = validators.ReadOnly
andyjianzhou commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640800647
##
tests/www/views/test_views_grid.py:
##
@@ -514,3 +515,59 @@ def test_next_run_datasets_404(admin_client):
resp = admin_client.get("/object/next_run_datas
aritra24 commented on code in PR #40254:
URL: https://github.com/apache/airflow/pull/40254#discussion_r1640781036
##
airflow/www/views.py:
##
@@ -271,7 +271,12 @@ def get_date_time_num_runs_dag_runs_form_data(www_request,
session, dag):
base_date = (date_time +
dateti
26 matches
Mail list logo
