Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
josh-fell commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2132231247 Congrats @vinay2242g 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2132227676 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-26 Thread via GitHub
josh-fell merged PR #39767: URL: https://github.com/apache/airflow/pull/39767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-24 Thread via GitHub
Taragolis commented on code in PR #39767: URL: https://github.com/apache/airflow/pull/39767#discussion_r1613803574 ## airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py: ## @@ -170,6 +172,8 @@ def __init__( self.quantiles = quantiles self.validation_

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-24 Thread via GitHub
Taragolis commented on code in PR #39767: URL: https://github.com/apache/airflow/pull/39767#discussion_r1613803574 ## airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py: ## @@ -170,6 +172,8 @@ def __init__( self.quantiles = quantiles self.validation_

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-24 Thread via GitHub
josh-fell commented on code in PR #39767: URL: https://github.com/apache/airflow/pull/39767#discussion_r1613655508 ## airflow/providers/google/cloud/hooks/vertex_ai/auto_ml.py: ## @@ -703,6 +705,10 @@ def create_auto_ml_forecasting_training_job( :param sync: Whether to

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-24 Thread via GitHub
shahar1 commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2129456268 > Thank you Shahar, > > Could you please let me if there any action item on my side? > > Thanks, Siddesh It looks good to me, but we need approval from a committer so

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-23 Thread via GitHub
vinay2242g commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2127381765 Thank you Shahar, Could you please let me if there any action item on my side? Thanks, Siddesh -- This is an automated message from the Apache Git Service. To r

Re: [PR] Adding params. to create_auto_ml_forecasting_training_job in AutoMl hook [airflow]

2024-05-23 Thread via GitHub
vinay2242g commented on PR #39767: URL: https://github.com/apache/airflow/pull/39767#issuecomment-2126656220 Thank you Shahar, I have tried to implement things that you have mentioned. Could you please let me know if they look good. Thanks, -- This is a