eladkal closed pull request #34894: Adding property files option in the Spark
Submit command
URL: https://github.com/apache/airflow/pull/34894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ghostp13409 commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-184986
> https://github.com/apache/airflow/pull/36164
> will be replacing this PR
> @ghostp13409 I have pulled your commits in, so your contribution will be
counted as well.
> we
pateash commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1849607706
https://github.com/apache/airflow/pull/36164
will be replace this
@ghostp13409 I have pulled your commits in, so your contribution will be
counted as well.
we can close this
Bowrna commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1844867253
@pateash @ghostp13409 if you need any help to push the fix for this issue,
let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
low ***@***.***>
Cc: ghostp13409 ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/airflow] Adding property files option in the Spark
Submit command (PR #34894)
Hi,
I have a related issue
#35911<https://github.com/apache/airflow/issues/35911>,
@ghostp13409&
pateash commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1829393995
Hi,
I have a related issue #35911,
@ghostp13409 if you are stuck, I can pull your branch into mine and merge
both changes and raise a PR.
let me know if that works.
cc.
ghostp13409 commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1814172175
> can you point out where you posted the question? @ghostp13409
I posted my question on
Bowrna commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1811813274
can you point out where you posted the question? @ghostp13409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ghostp13409 commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1810255498
> hi @ghostp13409 any update on this? if you are struck in this let me
know... i will see if i can support you. also some static checks are failing.
you may need to fix those parts
Bowrna commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1809548982
hi @ghostp13409 any update on this? if you are struck in this let me know...
i will see if i can support you. also some static checks are failing. you may
need to fix those parts too.
ghostp13409 commented on code in PR #34894:
URL: https://github.com/apache/airflow/pull/34894#discussion_r1358698178
##
airflow/providers/apache/spark/operators/spark_submit.py:
##
@@ -160,6 +160,11 @@ def on_kill(self) -> None:
self._hook = self._get_hook()
ghostp13409 commented on code in PR #34894:
URL: https://github.com/apache/airflow/pull/34894#discussion_r1357751380
##
airflow/providers/apache/spark/operators/spark_submit.py:
##
@@ -160,6 +160,11 @@ def on_kill(self) -> None:
self._hook = self._get_hook()
Bowrna commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1759958599
> > can this be tested with unit test?
>
> Hi @eladkal,
>
> As I mentioned above, I am a newcomer to open source and a also the
development as a whole. So I haven't done
Bowrna commented on code in PR #34894:
URL: https://github.com/apache/airflow/pull/34894#discussion_r1357074531
##
airflow/providers/apache/spark/operators/spark_submit.py:
##
@@ -160,6 +160,11 @@ def on_kill(self) -> None:
self._hook = self._get_hook()
ghostp13409 commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1759904842
> can this be tested with unit test?
Hi @eladkal,
As I mentioned above, I am a newcomer to open source and a also the
development as a whole. So I haven't done any
eladkal commented on PR #34894:
URL: https://github.com/apache/airflow/pull/34894#issuecomment-1759809180
can this be tested with unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
16 matches
Mail list logo
